hotfix(ci): fixed tests and style #37

Merged
devitq merged 4 commits from hotfix/fix-ci into develop 2026-05-03 18:12:10 +00:00
devitq commented 2026-05-03 16:17:07 +00:00 (Migrated from github.com)
No description provided.
coderabbitai[bot] commented 2026-05-03 16:17:15 +00:00 (Migrated from github.com)

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Free

Run ID: a1bb5855-df0a-4024-ae1d-cc80e1a72be9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: skip review by coderabbit.ai --> > [!IMPORTANT] > ## Review skipped > > Auto reviews are disabled on base/target branches other than the default branch. > > > > Please check the settings in the CodeRabbit UI or the `.coderabbit.yaml` file in this repository. To trigger a single review, invoke the `@coderabbitai review` command. > > <details> > <summary>⚙️ Run configuration</summary> > > **Configuration used**: Organization UI > > **Review profile**: ASSERTIVE > > **Plan**: Free > > **Run ID**: `a1bb5855-df0a-4024-ae1d-cc80e1a72be9` > > </details> > > You can disable this status message by setting the `reviews.review_status` to `false` in the CodeRabbit configuration file. > > Use the checkbox below for a quick retry: > - [ ] <!-- {"checkboxId": "e9bb8d72-00e8-4f67-9cb2-caf3b22574fe"} --> 🔍 Trigger review <!-- end of auto-generated comment: skip review by coderabbit.ai --> <!-- tips_start --> --- > [!NOTE] > <details> > <summary>🎁 Summarized by CodeRabbit Free</summary> > > Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting <https://app.coderabbit.ai/login>. > > </details> <sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub> <!-- tips_end -->
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2026-05-03 16:18:20 +00:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Pull request overview

This PR is a small CI/style hotfix that reformats Kotlin code to satisfy the repository’s enforced ktlint style without changing repository behavior. It touches one persistence test and one JDBC repository implementation.

Changes:

  • Reformat UserEntityMappingTest object construction to match Kotlin lint/style expectations.
  • Reformat UserRepository.findAll() chaining for style consistency.
  • Convert one SQL statement in UserRepository.findByProviderAndProviderId() to a multiline string with trimIndent().

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/test/kotlin/com/project/movienight/adapters/persistence/entity/UserEntityMappingTest.kt Test-only formatting cleanup for entity/domain mapping tests.
src/main/kotlin/com/project/movienight/adapters/persistence/jdbc/UserRepository.kt Style-only formatting changes in query construction and method chaining.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

## Pull request overview This PR is a small CI/style hotfix that reformats Kotlin code to satisfy the repository’s enforced ktlint style without changing repository behavior. It touches one persistence test and one JDBC repository implementation. **Changes:** - Reformat `UserEntityMappingTest` object construction to match Kotlin lint/style expectations. - Reformat `UserRepository.findAll()` chaining for style consistency. - Convert one SQL statement in `UserRepository.findByProviderAndProviderId()` to a multiline string with `trimIndent()`. ### Reviewed changes Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments. | File | Description | | ---- | ----------- | | `src/test/kotlin/com/project/movienight/adapters/persistence/entity/UserEntityMappingTest.kt` | Test-only formatting cleanup for entity/domain mapping tests. | | `src/main/kotlin/com/project/movienight/adapters/persistence/jdbc/UserRepository.kt` | Style-only formatting changes in query construction and method chaining. | --- 💡 <a href="/devitq/movienight-backend/new/main?filename=.github/instructions/*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2026-05-03 16:54:14 +00:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

## Pull request overview Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment. --- 💡 <a href="/devitq/movienight-backend/new/main?filename=.github/instructions/*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.
@@ -5,1 +5,4 @@
provider VARCHAR(64),
provider_id VARCHAR(255),
created_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP
);
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2026-05-03 16:54:14 +00:00

Editing an existing V1__init.sql migration will break deployments on any environment that has already applied version 1, because Flyway validates migration checksums and will fail startup when a previously executed migration changes. This needs to be introduced as a new forward-only migration instead of rewriting V1.

Editing an existing `V1__init.sql` migration will break deployments on any environment that has already applied version 1, because Flyway validates migration checksums and will fail startup when a previously executed migration changes. This needs to be introduced as a new forward-only migration instead of rewriting `V1`.
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2026-05-03 17:20:26 +00:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

## Pull request overview Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment. --- 💡 <a href="/devitq/movienight-backend/new/main?filename=.github/instructions/*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.
@@ -5,1 +5,4 @@
provider VARCHAR(64),
provider_id VARCHAR(255),
created_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP
);
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2026-05-03 17:20:26 +00:00

This changes the contents of the already-versioned V1__init.sql migration instead of adding a new migration. Flyway will not re-run V1 in environments that have already applied it, so those databases will still be missing provider, provider_id, and created_at, and the updated repository queries will start failing at runtime when they select these columns.

This changes the contents of the already-versioned `V1__init.sql` migration instead of adding a new migration. Flyway will not re-run `V1` in environments that have already applied it, so those databases will still be missing `provider`, `provider_id`, and `created_at`, and the updated repository queries will start failing at runtime when they select these columns.
Sign in to join this conversation.