ITQ/movienight-backend
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

test: write tests for controllers #24

Merged
devitq merged 11 commits from feat/spring-tests into develop 2026-05-08 20:32:36 +00:00
Conversation 12 Commits 11 Files Changed 8
+17
2 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8926e5b08c - Show all commits
src/main/kotlin/com/project/movienight/adapters/web/FilmController.kt
+9
View File
@@ -1,5 +1,6 @@
package com.project.movienight.adapters.web
copilot-pull-request-reviewer[bot] commented 2026-04-21 18:32:36 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

There are multiple consecutive blank lines after the package declaration here; ktlint will flag consecutive blank lines. Collapse this to a single blank line before the imports.
There are multiple consecutive blank lines after the `package` declaration here; ktlint will flag consecutive blank lines. Collapse this to a single blank line before the imports. ```suggestion ```
import com.project.movienight.adapters.web.dto.request.CreateFilmRequest
import com.project.movienight.adapters.web.dto.request.EditFilmRequest
import com.project.movienight.adapters.web.dto.response.FilmResponse
@@ -10,6 +11,14 @@ import com.project.movienight.application.ports.input.EditFilmCommand
import com.project.movienight.application.ports.input.EditFilmUseCase
import com.project.movienight.application.services.FilmService
import org.springframework.http.HttpStatus
import org.springframework.web.bind.annotation.DeleteMapping
import org.springframework.web.bind.annotation.PatchMapping
import org.springframework.web.bind.annotation.PathVariable
import org.springframework.web.bind.annotation.PostMapping
import org.springframework.web.bind.annotation.RequestBody
import org.springframework.web.bind.annotation.RequestMapping
copilot-pull-request-reviewer[bot] commented 2026-04-21 18:32:36 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

org.springframework.web.bind.annotation.* is a wildcard import and is redundant with the explicit annotation imports above; ktlint (enabled in this repo) will fail on wildcard/redundant imports. Replace the wildcard import with only the specific annotations you use (and remove any duplicates).

`org.springframework.web.bind.annotation.*` is a wildcard import and is redundant with the explicit annotation imports above; ktlint (enabled in this repo) will fail on wildcard/redundant imports. Replace the wildcard import with only the specific annotations you use (and remove any duplicates).
import org.springframework.web.bind.annotation.ResponseStatus
import org.springframework.web.bind.annotation.RestController
import org.springframework.web.bind.annotation.*
import java.util.UUID
1
src/main/kotlin/com/project/movienight/adapters/web/FilmLibraryController.kt
+8
View File
@@ -13,6 +13,14 @@ import com.project.movienight.application.ports.input.RemoveFilmFromLibraryComma
import com.project.movienight.application.ports.input.RemoveFilmFromLibraryUseCase
import com.project.movienight.application.services.FilmService
import org.springframework.http.HttpStatus
import org.springframework.web.bind.annotation.DeleteMapping
import org.springframework.web.bind.annotation.GetMapping
import org.springframework.web.bind.annotation.PathVariable
import org.springframework.web.bind.annotation.PostMapping
import org.springframework.web.bind.annotation.RequestBody
import org.springframework.web.bind.annotation.RequestMapping
copilot-pull-request-reviewer[bot] commented 2026-04-21 18:32:37 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

org.springframework.web.bind.annotation.* is a wildcard import and is redundant with the explicit annotation imports above; ktlint (enabled in this repo) will fail on wildcard/redundant imports. Replace the wildcard import with only the specific annotations you use (and remove any duplicates).
`org.springframework.web.bind.annotation.*` is a wildcard import and is redundant with the explicit annotation imports above; ktlint (enabled in this repo) will fail on wildcard/redundant imports. Replace the wildcard import with only the specific annotations you use (and remove any duplicates). ```suggestion ```
import org.springframework.web.bind.annotation.ResponseStatus
import org.springframework.web.bind.annotation.RestController
import org.springframework.web.bind.annotation.*
import java.util.UUID
3