fix: address PR review comments for OAuth2 implementation #32

Merged
skettiks merged 25 commits from feat/oauth2-user-service-26 into develop 2026-05-16 19:30:55 +00:00
2 changed files with 2 additions and 7 deletions
Showing only changes of commit bc06654c84 - Show all commits
+1 -6
View File
@@ -9,15 +9,13 @@ plugins {
alias(libs.plugins.kotlin.spring)
devitq commented 2026-05-15 19:39:02 +00:00 (Migrated from github.com)
Review

restore AOT

restore AOT
devitq commented 2026-05-15 19:39:51 +00:00 (Migrated from github.com)
Review

we don't need graalvm, we'll stick with default Java runtime

we don't need graalvm, we'll stick with default Java runtime
alias(libs.plugins.spring.boot)
alias(libs.plugins.spring.dependency.management)
id("org.graalvm.buildtools.native") version "0.10.5"
alias(libs.plugins.protobuf)
alias(libs.plugins.ktlint)
alias(libs.plugins.detekt)
devitq commented 2026-05-08 17:32:26 +00:00 (Migrated from github.com)
Review

nope, you are not allowed to disable AOT
figure out how to resolve issues

nope, you are not allowed to disable AOT figure out how to resolve issues
jacoco
}
// Temporarily disabled due to OAuth2 AOT processing issues
// apply(plugin = "org.springframework.boot.aot")
apply(from = "$rootDir/gradle/docker.gradle.kts")
group = "com.project"
2
@@ -73,7 +71,6 @@ tasks.withType<KotlinCompile> {
jvmTarget.set(JvmTarget.JVM_21)
allWarningsAsErrors.set(false)
}
exclude("**/security.disabled/**")
}
tasks.withType<JavaCompile> {
2
@@ -156,7 +153,6 @@ ktlint {
filter {
exclude("**/build/**")
exclude("**/generated/**")
exclude("**/security.disabled/**")
}
}
1
@@ -170,7 +166,6 @@ detekt {
tasks.withType<Detekt>().configureEach {
jvmTarget = "21"
exclude("**/security.disabled/**")
reports {
html.required.set(true)
xml.required.set(true)
1
+1 -1
View File
@@ -8,5 +8,5 @@ kotlin.incremental=true
kotlin.incremental.js=true
devitq commented 2026-05-15 19:33:54 +00:00 (Migrated from github.com)
Review

Why you've disabled configuration cache...

Why you've disabled configuration cache...
kotlin.incremental.multiplatform=true
org.gradle.configuration-cache=true
org.gradle.configuration-cache=false
org.gradle.unsafe.configuration-cache-problems=warn