ITQ/movienight-backend
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: address PR review comments for OAuth2 implementation #32

Merged
skettiks merged 25 commits from feat/oauth2-user-service-26 into develop 2026-05-16 19:30:55 +00:00
Conversation 17 Commits 25 Files Changed 19
+7 -2
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d2821a8439 - Show all commits
build.gradle.kts
+6 -1
View File
@@ -9,13 +9,15 @@ plugins {
alias(libs.plugins.kotlin.spring)
devitq commented 2026-05-15 19:39:02 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

restore AOT

restore AOT
devitq commented 2026-05-15 19:39:51 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

we don't need graalvm, we'll stick with default Java runtime

we don't need graalvm, we'll stick with default Java runtime
alias(libs.plugins.spring.boot)
alias(libs.plugins.spring.dependency.management)
id("org.graalvm.buildtools.native") version "0.10.5"
alias(libs.plugins.protobuf)
alias(libs.plugins.ktlint)
alias(libs.plugins.detekt)
jacoco
devitq commented 2026-05-08 17:32:26 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

nope, you are not allowed to disable AOT
figure out how to resolve issues

nope, you are not allowed to disable AOT figure out how to resolve issues
}
// Temporarily disabled due to OAuth2 AOT processing issues
// apply(plugin = "org.springframework.boot.aot")
apply(from = "$rootDir/gradle/docker.gradle.kts")
group = "com.project"
2
 @@ -71,6 +73,7 @@ tasks.withType<KotlinCompile> {
jvmTarget.set(JvmTarget.JVM_21)
allWarningsAsErrors.set(false)
}
exclude("**/security.disabled/**")
}
devitq commented 2026-05-08 17:36:32 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

for what you've excluded security.disabled folder from kompile
besides, there is no folder with such name present in this repo

for what you've excluded security.disabled folder from kompile besides, there is no folder with such name present in this repo
tasks.withType<JavaCompile> {
1
 @@ -153,6 +156,7 @@ ktlint {
filter {
exclude("**/build/**")
exclude("**/generated/**")
exclude("**/security.disabled/**")
}
}
devitq commented 2026-05-08 17:36:54 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

same issue addressed in R81 line comment

same issue addressed in R81 line comment
@@ -166,6 +170,7 @@ detekt {
tasks.withType<Detekt>().configureEach {
jvmTarget = "21"
exclude("**/security.disabled/**")
reports {
html.required.set(true)
devitq commented 2026-05-08 17:36:58 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

same issue addressed in R81 line comment

same issue addressed in R81 line comment
xml.required.set(true)
gradle.properties
+1 -1
View File
@@ -8,5 +8,5 @@ kotlin.incremental=true
kotlin.incremental.js=true
devitq commented 2026-05-15 19:33:54 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Why you've disabled configuration cache...

Why you've disabled configuration cache...
kotlin.incremental.multiplatform=true
org.gradle.configuration-cache=false
org.gradle.configuration-cache=true
org.gradle.unsafe.configuration-cache-problems=warn