ITQ/movienight-backend
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

hotfix(ci): fixed tests and style #37

Merged
devitq merged 4 commits from hotfix/fix-ci into develop 2026-05-03 18:12:10 +00:00
Conversation 4 Commits 4 Files Changed 9
+12 -7
2 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 02d3f4580d - Show all commits
src/main/kotlin/com/project/movienight/adapters/web/FilmLibraryController.kt
+8 -6
View File
@@ -74,10 +74,12 @@ class FilmLibraryController(
fun removeFilm(
@PathVariable userId: UUID,
@PathVariable filmId: UUID,
) = removeFilmFromLibraryUseCase.removeFilm(
RemoveFilmFromLibraryCommand(
userId = userId,
filmId = filmId,
),
)
) {
removeFilmFromLibraryUseCase.removeFilm(
RemoveFilmFromLibraryCommand(
userId = userId,
filmId = filmId,
),
)
}
}
src/main/resources/db/migration/V1__init.sql
+4 -1
View File
@@ -1,7 +1,10 @@
CREATE TABLE IF NOT EXISTS public.users (
id UUID PRIMARY KEY,
name VARCHAR(255) NOT NULL,
email VARCHAR(320) NOT NULL UNIQUE
email VARCHAR(320) NOT NULL UNIQUE,
provider VARCHAR(64),
provider_id VARCHAR(255),
created_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP
);
copilot-pull-request-reviewer[bot] commented 2026-05-03 16:54:14 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Editing an existing V1__init.sql migration will break deployments on any environment that has already applied version 1, because Flyway validates migration checksums and will fail startup when a previously executed migration changes. This needs to be introduced as a new forward-only migration instead of rewriting V1.

Editing an existing `V1__init.sql` migration will break deployments on any environment that has already applied version 1, because Flyway validates migration checksums and will fail startup when a previously executed migration changes. This needs to be introduced as a new forward-only migration instead of rewriting `V1`.
copilot-pull-request-reviewer[bot] commented 2026-05-03 17:20:26 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

This changes the contents of the already-versioned V1__init.sql migration instead of adding a new migration. Flyway will not re-run V1 in environments that have already applied it, so those databases will still be missing provider, provider_id, and created_at, and the updated repository queries will start failing at runtime when they select these columns.

This changes the contents of the already-versioned `V1__init.sql` migration instead of adding a new migration. Flyway will not re-run `V1` in environments that have already applied it, so those databases will still be missing `provider`, `provider_id`, and `created_at`, and the updated repository queries will start failing at runtime when they select these columns.
CREATE TABLE IF NOT EXISTS public.films (