mirror of
https://github.com/submariner-io/submariner-charts.git
synced 2026-09-20 20:20:35 +00:00
Check for fixup commits in PRs
Commits produced using "git commit --fix" are great for review, but must be squashed before a PR is merged. Signed-off-by: Stephen Kitt <skitt@redhat.com>
This commit is contained in:
committed by
Thomas Pantelis
parent
b6590df91b
commit
76c4e94da1
@@ -23,6 +23,14 @@ jobs:
|
||||
flags: 'i'
|
||||
error: 'Commits addressing code review feedback should typically be squashed into the commits under review'
|
||||
|
||||
- name: 'Verify no "fixup!" commits'
|
||||
uses: tim-actions/commit-message-checker-with-regex@d6d9770051dd6460679d1cab1dcaa8cffc5c2bbd
|
||||
with:
|
||||
commits: ${{ steps.get-pr-commits.outputs.commits }}
|
||||
pattern: '^(?!fixup!)'
|
||||
flags: 'i'
|
||||
error: 'Fixup commits should be squashed into the commits under review'
|
||||
|
||||
chart-testing:
|
||||
name: Helm Chart Linting
|
||||
runs-on: ubuntu-latest
|
||||
|
||||
Reference in New Issue
Block a user