ITQ/submariner-charts
1
0
Fork 0
mirror of https://github.com/submariner-io/submariner-charts.git synced 2026-09-22 14:20:36 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Check for fixup commits in PRs

Browse Source 
Commits produced using "git commit --fix" are great for review, but
must be squashed before a PR is merged.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
This commit is contained in:
Stephen Kitt
2022-01-20 14:13:24 -05:00
committed by Thomas Pantelis
parent b6590df91b
commit 76c4e94da1
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/linting.yml
+8
View File
@@ -23,6 +23,14 @@ jobs:
flags: 'i' flags: 'i'
error: 'Commits addressing code review feedback should typically be squashed into the commits under review' error: 'Commits addressing code review feedback should typically be squashed into the commits under review'
- name: 'Verify no "fixup!" commits'
uses: tim-actions/commit-message-checker-with-regex@d6d9770051dd6460679d1cab1dcaa8cffc5c2bbd
with:
commits: ${{ steps.get-pr-commits.outputs.commits }}
pattern: '^(?!fixup!)'
flags: 'i'
error: 'Fixup commits should be squashed into the commits under review'
chart-testing: chart-testing:
name: Helm Chart Linting name: Helm Chart Linting
runs-on: ubuntu-latest runs-on: ubuntu-latest