From 7cc50b03d3f6e3bc4fa75a6db344dea87693dea3 Mon Sep 17 00:00:00 2001 From: Sridhar Gaddam Date: Sat, 11 Jul 2020 00:27:14 +0530 Subject: [PATCH] Reset terminationGracePeriodSeconds for SM Pods (#50) In one of the earlier PRs, we modified the terminationGracePeriodSeconds to 10 secs. However, its seen that this is causing more CI failures during e2e redundancy tests. Ideally, once the Pods are terminated, it should cleanup itself ASAP but it is seen that SM Pods are sometimes taking time to exit and during this Period since there is no active SM Pod running, this is triggering some failures. Until we figure out the exact reason why the Pods are taking time for cleanup, this PR reduces the terminationGracePeriodSeconds. This issue would be properly addressed via https://github.com/submariner-io/submariner/issues/694 Signed-Off-by: Sridhar Gaddam --- submariner/templates/engine-deploy.yaml | 2 +- submariner/templates/globalnet.yaml | 2 +- submariner/templates/route-agent-ds.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/submariner/templates/engine-deploy.yaml b/submariner/templates/engine-deploy.yaml index eb837f2..17352a4 100644 --- a/submariner/templates/engine-deploy.yaml +++ b/submariner/templates/engine-deploy.yaml @@ -130,5 +130,5 @@ spec: restartPolicy: Always schedulerName: default-scheduler securityContext: {} - terminationGracePeriodSeconds: 10 + terminationGracePeriodSeconds: 1 serviceAccountName: {{ template "submariner.engineServiceAccountName" . }} diff --git a/submariner/templates/globalnet.yaml b/submariner/templates/globalnet.yaml index 20df3e0..7a52eac 100644 --- a/submariner/templates/globalnet.yaml +++ b/submariner/templates/globalnet.yaml @@ -25,7 +25,7 @@ spec: hostNetwork: true serviceAccountName: submariner-globalnet serviceAccount: submariner-globalnet - terminationGracePeriodSeconds: 10 + terminationGracePeriodSeconds: 2 nodeSelector: submariner.io/gateway: 'true' containers: diff --git a/submariner/templates/route-agent-ds.yaml b/submariner/templates/route-agent-ds.yaml index 094ccdc..2f6f919 100644 --- a/submariner/templates/route-agent-ds.yaml +++ b/submariner/templates/route-agent-ds.yaml @@ -26,7 +26,7 @@ spec: component: routeagent spec: serviceAccountName: {{ template "submariner.routeAgentServiceAccountName" . }} - terminationGracePeriodSeconds: 10 + terminationGracePeriodSeconds: 1 hostNetwork: true containers: - name: routeagent