From d38625a9fdc9b92d68e10c694d992453a7c7994d Mon Sep 17 00:00:00 2001 From: Sridhar Gaddam Date: Tue, 21 Jul 2020 18:20:22 +0530 Subject: [PATCH] Modify updateStrategy for Route-agent Pods Currently, the updateStrategy for Route-agent pods is set to RollingUpdate with maxUnavailable as 1. Because of this, when the route-agent DaemonSet is updated, the Pods are updated one after the other. While the rolling update strategy is good for user-facing services, for route-agent DaemonSet its not the most suitable one as it takes time for all the route-agent pods to be updated in a large cluster. Ideally, it would have been great if "Recreate" updateStrategy was supported for DaemonSets, but unfortunately K8s does not support it. But an alternate way to achieve something similar is to configure rollingUpdate.maxUnavailable to 100% so that the DaemonSet controller can update all the route-agent Pods in a single go. https://kubernetes.io/docs/tasks/manage-daemon/update-daemon-set/#daemonset-update-strategy Fixes issue: https://github.com/submariner-io/submariner/issues/734 Signed-Off-by: Sridhar Gaddam --- submariner/templates/route-agent-ds.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/submariner/templates/route-agent-ds.yaml b/submariner/templates/route-agent-ds.yaml index 2f6f919..5a05201 100644 --- a/submariner/templates/route-agent-ds.yaml +++ b/submariner/templates/route-agent-ds.yaml @@ -14,7 +14,7 @@ spec: app: {{ template "submariner.fullname" . }}-routeagent updateStrategy: rollingUpdate: - maxUnavailable: 1 + maxUnavailable: "100%" type: RollingUpdate template: metadata: @@ -75,4 +75,4 @@ spec: volumes: - name: host-slash hostPath: - path: / \ No newline at end of file + path: /