Fix yamllint errors, use SubM-standard config

Use similar yamllint configuration as other Submariner repos.

Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

.github/workflows/linting.yml

@@ -107,6 +107,5 @@ jobs:
       - name: Run yamllint
         uses: ibiqlik/action-yamllint@ed2b6e911569708ed121c14b87d513860a7e36a7
         with:
-          file_or_dir: submariner-k8s-broker/Chart.yaml submariner-k8s-broker/values.yaml submariner-operator/Chart.yaml submariner-operator/values.yaml
           config_file: .yamllint.yml
           strict: true

.submarinerbot.yaml

@@ -1,3 +1,4 @@
+---
 label-approved:
   approvals: 2
   label: ready-to-test

.yamllint.yml

@@ -1,15 +1,15 @@
 ---
 extends: default
+
 rules:
-  comments: disable
-  comments-indentation: disable
   line-length:
-    max: 150
-  braces:
-    min-spaces-inside: 0
-    max-spaces-inside: 0
-  brackets:
-    min-spaces-inside: 0
-    max-spaces-inside: 0
-  indentation:
-    indent-sequences: consistent
+    max: 140
+  # Allow standard GHA syntax for "on: *"
+  truthy:
+    ignore: '.github/workflows/*.yml'
+
+ignore: |
+  /submariner-k8s-broker/crds
+  /submariner-operator/crds
+  /submariner-k8s-broker/templates
+  /submariner-operator/templates

ct.yaml

@@ -1,3 +1,4 @@
+---
 charts:
   - submariner-operator
   - submariner-k8s-broker

submariner-k8s-broker/questions.yml

@@ -1,17 +1,18 @@
+---
 questions:
-- variable: submariner-k8s-broker.rbac.create
+  - variable: submariner-k8s-broker.rbac.create
     type: boolean
     default: true
     group: "Role Based Access Control"
     description: "Create the role/rolebinding for the Submariner client"
     label: "RBAC Creation Enabled"
-- variable: submariner-k8s-broker.crd.create
+  - variable: submariner-k8s-broker.crd.create
     type: boolean
     default: true
     group: "Submariner CRD"
     description: "Create the submariner CRDs for the Submariner client"
     label: "Submariner CRD Creation Enabled"
-- variable: submariner-k8s-broker.serviceAccounts.client.create
+  - variable: submariner-k8s-broker.serviceAccounts.client.create
     type: boolean
     default: true
     group: "Service Account"

submariner-operator/questions.yml

@@ -1,5 +1,6 @@
+---
 questions:
-- variable: defaultOperatorImage
+  - variable: defaultOperatorImage
     default: true
     description: "Use default Submariner operator image or specify a custom one"
     label: Use default Submariner operator image
@@ -17,7 +18,7 @@ questions:
         description: "Submariner Operator Image Tag"
         type: string
         label: Submariner Operator Image Tag
-- variable: defaultSubmarinerImages
+  - variable: defaultSubmarinerImages
     default: true
     description: "Use default Submariner images or specify custom ones"
     label: Use default Submariner images
@@ -35,27 +36,27 @@ questions:
         description: "Submariner Images Tag (shared for all non-operator images)"
         type: string
         label: Submariner Images Tag
-- variable: submariner.clusterId
+  - variable: submariner.clusterId
     default: ""
     description: "Enter a unique cluster ID to identify this cluster"
     type: string
     label: "Cluster ID"
     group: "Configuration"
     required: true
-- variable: ipsec.psk
+  - variable: ipsec.psk
     default: ""
     description: "Enter the pre-shared key for the IPsec Cable Engine"
     type: string
     label: "IPsec Pre-Shared Key"
     group: "Configuration"
     required: true
-- variable: broker.server
+  - variable: broker.server
     type: string
     default: ""
     group: "Broker Configuration"
     label: "Broker Server"
     description: "Broker server to use (without the https://)"
-- variable: broker.insecure
+  - variable: broker.insecure
     type: boolean
     default: false
     show_subquestion_if: false
@@ -68,37 +69,37 @@ questions:
         description: "Base64 encoded broker ca.crt"
         label: "Broker CA encoded in base64"
         default: ""
-- variable: broker.token
+  - variable: broker.token
     type: string
     group: "Broker Configuration"
     label: "Broker Token"
     description: "Bearer token for broker"
-- variable: broker.namespace
+  - variable: broker.namespace
     type: string
     group: "Broker Configuration"
     label: "Broker Namespace"
     description: "Enter namespace to use on central broker"
-- variable: submariner.clusterCidr
+  - variable: submariner.clusterCidr
     default: ""
     description: "Enter the cluster CIDR (i.e. 10.42.0.0/16) for this cluster"
     type: string
     label: "Cluster CIDR"
     group: "CIDR Configuration"
     required: true
-- variable: submariner.serviceCidr
+  - variable: submariner.serviceCidr
     default: ""
     description: "Enter the service CIDR (i.e. 10.43.0.0/16) for this cluster"
     type: string
     label: "Service CIDR"
     group: "CIDR Configuration"
     required: true
-- variable: submariner.serviceDiscovery
+  - variable: submariner.serviceDiscovery
     type: boolean
     default: false
     group: "Advanced Configuration"
     description: "Enable multicluster service discovery"
     label: "Service Discovery Enabled"
-- variable: broker.globalnet
+  - variable: broker.globalnet
     type: boolean
     default: false
     group: "Broker Configuration"
@@ -112,31 +113,31 @@ questions:
         label: "Globalnet CIDR"
         group: "CIDR Configuration"
         required: false
-- variable: submariner.natEnabled
+  - variable: submariner.natEnabled
     type: boolean
     default: false
     group: "Advanced Configuration"
     description: "If the gateway nodes for this cluster are behind 1:1 NAT, you should enable NAT"
     label: "NAT Enabled"
-- variable: submariner.debug
+  - variable: submariner.debug
     type: boolean
     default: false
     group: "Advanced Configuration"
     description: "Enable submariner debug mode"
     label: "Submariner Debug Enabled"
-- variable: ipsec.debug
+  - variable: ipsec.debug
     type: boolean
     default: false
     group: "Advanced Configuration"
     description: "Enable Charon debug mode"
     label: "Charon Enabled"
-- variable: submariner.cableDriver
+  - variable: submariner.cableDriver
     type: string
     default: ""
     group: "Advanced Configuration"
     description: "Cable driver implementation"
     label: "Cable Driver"
-- variable: submariner.healthcheckEnabled
+  - variable: submariner.healthcheckEnabled
     type: boolean
     default: true
     group: "Advanced Configuration"