Use the yamlint make target provided by Shipyard instead of a third
party GitHub action for running the same tool.
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
This adds a feature, but nothing that seems relevant to us.
github.com/tim-actions/get-pr-commits/compare/v1.1.0...v1.2.0
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Bumps the version of markdown-link-check from 3.8.7 to 3.9.3.
Changes base image from node:alpine to node:lts-alpine.
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Commits produced using "git commit --fix" are great for review, but
must be squashed before a PR is merged.
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Per GitHub's security guidelines, GHAs should be pinned using full
length commit SHAs instead of tags.
The SHAs are of the commits currently resolved by the versions.
Even "trusted" GHAs from GitHub developers are pinned because it's
possible their repo rights could be compromised and a malicious GHA
published. These core repos are not frequently substantially updated.
Submariner-internal GHAs are left pinned at devel because we want
automatic updates from Shipyard's shared tooling.
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Add a linting job to verify that no commit message in a PR contains the
case insensitive string "Apply suggestions from code review". Commits
with exactly this title are generated by GitHub automatically when a
batch of proposed changes from code review are accepted from the GitHub
UI. A number of such commits have made it into various Submariner/*
repos.
Commits addressing code review feedback should typically be squashed
into the commits under review, or made into well-commented discrete
commits.
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
This was deprecated in favour of the operator-based chart. This only
removes the Submariner chart, the broker chart will be addressed
separately.
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Instead of an external GitHub action, use the same markdownlint make
target from Shipyard that we use in other repos.
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
To determine the changed files, the Markdown linter needs to know the
base branch; instead of using the default everywhere, use the base
branch set in the PR.
Signed-off-by: Stephen Kitt <skitt@redhat.com>
The submariner-operator Helm chart deploys Submariner using the
Submariner operator: it deploys the CRDs, roles, and SAs required to
run the operator and Submariner, then pushes a Submariner CR to
instruct the operator to deploy Submariner.
This patch also adds a Makefile to validate the deployments; run
make deploy
to test the Helm charts (this will bring up two clusters, install the
broker on one of them and the operator on both, and end with a
connectivity test).
Fixes: #17
Signed-off-by: Stephen Kitt <skitt@redhat.com>
YAML linting currently runs on Travis. Convert to a GHA, to align with
other repos and prepare for future optimizations.
Only run against values.yaml and Chart.yaml files, as is currently the
case in the Travis-driven workflow.
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Combine linting GitHub Actions into a single Workflow.
Minor updates to reflect refactoring in other repos.
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
