refactor: rename submariner-engine to submariner-gateway (#122)

Signed-off-by: Steve Mattar <smattar@redhat.com>

.github/workflows/e2e.yml

@@ -11,12 +11,16 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
+      matrix:
+        globalnet: ['', 'globalnet']
     steps:
       - name: Check out the repository
         uses: actions/checkout@v2
 
       - name: Run E2E deployment and tests
         uses: submariner-io/shipyard/gh-actions/e2e@devel
+        with:
+          globalnet: ${{ matrix.globalnet }}
 
       - name: Post mortem
         if: failure()

Makefile

@@ -22,9 +22,8 @@ e2e: E2E_ARGS=cluster1 cluster2
 preload-images:
 	source $(SCRIPTS_DIR)/lib/debug_functions; \
 	source $(SCRIPTS_DIR)/lib/deploy_funcs; \
-	source $(SCRIPTS_DIR)/lib/version; \
 	set -e; \
-	for image in submariner submariner-route-agent submariner-operator lighthouse-agent submariner-globalnet lighthouse-coredns; do \
+	for image in submariner-gateway submariner-route-agent submariner-operator lighthouse-agent submariner-globalnet lighthouse-coredns; do \
 		import_image quay.io/submariner/$${image}; \
 	done
 

submariner-operator/crds/crd.yaml

@@ -105,7 +105,7 @@ spec:
               type: string
             colorCodes:
               type: string
-            engineDaemonSetStatus:
+            gatewayDaemonSetStatus:
               properties:
                 lastResourceVersion:
                   type: string

submariner-operator/questions.yml

@@ -92,6 +92,13 @@ questions:
   label: "Service CIDR"
   group: "CIDR Configuration"
   required: true
+- variable: submariner.globalCidr
+  default: ""
+  description: "Enter the globalnet CIDR (i.e. 169.254.1.0/24) for this cluster if using globalnet"
+  type: string
+  label: "Globalnet CIDR"
+  group: "CIDR Configuration"
+  required: false
 - variable: submariner.natEnabled
   type: boolean
   default: false

submariner-operator/templates/NOTES.txt

@@ -1,6 +1,6 @@
 Submariner is now installed.
 
-{{- if .Values.engine.nodeSelectorEnabled }}
+{{- if .Values.gateway.nodeSelectorEnabled }}
 If you haven't done so yet, please label a node as `submariner.io/gateway=true` to elect it for running Submariner.
 {{- end }}
 

submariner-operator/templates/_helpers.tpl

@@ -43,13 +43,13 @@ Create the name of the submariner-operator service account to use
 {{- end -}}
 
 {{/*
-Create the name of the submariner-engine service account to use
+Create the name of the submariner-gateway service account to use
 */}}
-{{- define "submariner.engineServiceAccountName" -}}
+{{- define "submariner.gatewayServiceAccountName" -}}
-{{- if .Values.serviceAccounts.engine.create -}}
+{{- if .Values.serviceAccounts.gateway.create -}}
-    {{ default "submariner-engine" .Values.serviceAccounts.engine.name }}
+    {{ default "submariner-gateway" .Values.serviceAccounts.gateway.name }}
 {{- else -}}
-    {{ default "default" .Values.serviceAccounts.engine.name }}
+    {{ default "default" .Values.serviceAccounts.gateway.name }}
 {{- end -}}
 {{- end -}}
 

submariner-operator/templates/operator-deployment.yaml

@@ -6,7 +6,7 @@ metadata:
     release: {{ .Release.Name | quote }}
     chart: {{ template "submariner.chart" . }}
     app: {{ template "submariner.fullname" . }}
-    component: engine
+    component: gateway
   name: {{ template "submariner.fullname" . }}
 spec:
   progressDeadlineSeconds: 600

submariner-operator/templates/rbac.yaml

@@ -86,7 +86,7 @@ roleRef:
 apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:
-  name: {{ template "submariner.fullname" . }}:engine
+  name: {{ template "submariner.fullname" . }}:gateway
   labels:
     heritage: {{ .Release.Service | quote }}
     release: {{ .Release.Name | quote }}
@@ -166,7 +166,7 @@ rules:
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
-  name: {{ template "submariner.fullname" . }}:engine
+  name: {{ template "submariner.fullname" . }}:gateway
   labels:
     heritage: {{ .Release.Service | quote }}
     release: {{ .Release.Name | quote }}
@@ -175,10 +175,10 @@ metadata:
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: Role
-  name: {{ template "submariner.fullname" . }}:engine
+  name: {{ template "submariner.fullname" . }}:gateway
 subjects:
 - kind: ServiceAccount
-  name: {{ template "submariner.engineServiceAccountName" . }}
+  name: {{ template "submariner.gatewayServiceAccountName" . }}
   namespace: {{ .Release.Namespace }}
 ---
 apiVersion: rbac.authorization.k8s.io/v1
@@ -458,7 +458,7 @@ roleRef:
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
-  name: {{ template "submariner.fullname" . }}:engine
+  name: {{ template "submariner.fullname" . }}:gateway
   labels:
     heritage: {{ .Release.Service | quote }}
     release: {{ .Release.Name | quote }}
@@ -525,7 +525,7 @@ rules:
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
-  name: {{ template "submariner.fullname" . }}:engine
+  name: {{ template "submariner.fullname" . }}:gateway
   labels:
     heritage: {{ .Release.Service | quote }}
     release: {{ .Release.Name | quote }}
@@ -534,10 +534,10 @@ metadata:
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: ClusterRole
-  name: {{ template "submariner.fullname" . }}:engine
+  name: {{ template "submariner.fullname" . }}:gateway
 subjects:
   - kind: ServiceAccount
-    name: {{ template "submariner.engineServiceAccountName" . }}
+    name: {{ template "submariner.gatewayServiceAccountName" . }}
     namespace: {{ .Release.Namespace }}
 ---
 apiVersion: rbac.authorization.k8s.io/v1

submariner-operator/templates/submariner.yaml

@@ -22,4 +22,5 @@ spec:
   repository: {{ .Values.submariner.images.repository }}
   version: {{ .Values.submariner.images.tag }}
   serviceCIDR: "{{ .Values.submariner.serviceCidr }}"
+  globalCIDR: "{{ .Values.submariner.globalCidr }}"
   serviceDiscoveryEnabled: {{ .Values.submariner.serviceDiscovery }}

submariner-operator/templates/svc-acct.yaml

@@ -10,11 +10,11 @@ metadata:
     app: {{ template "submariner.name" . }}
 {{- end }}
 ---
-{{- if .Values.serviceAccounts.engine.create }}
+{{- if .Values.serviceAccounts.gateway.create }}
 apiVersion: v1
 kind: ServiceAccount
 metadata:
-  name: {{ template "submariner.engineServiceAccountName" . }}
+  name: {{ template "submariner.gatewayServiceAccountName" . }}
   labels:
     heritage: {{ .Release.Service | quote }}
     release: {{ .Release.Name | quote }}

submariner-operator/values.yaml

@@ -37,15 +37,15 @@ operator:
   resources: {}
   tolerations: []
   affinity: {}
-engine:
+gateway:
   image:
-    repository: quay.io/submariner/submariner
+    repository: quay.io/submariner/submariner-gateway
     tag: "0.7.0"
 serviceAccounts:
   operator:
     create: true
     name: ""
-  engine:
+  gateway:
     create: true
     name: ""
   routeAgent:

submariner/questions.yml

@@ -1,22 +1,22 @@
 questions:
-- variable: defaultEngineImage
+- variable: defaultGatewayImage
   default: true
-  description: "Use default Submariner Engine image or specify a custom one"
+  description: "Use default Submariner Gateway image or specify a custom one"
-  label: Use default submariner engine image
+  label: Use default submariner gateway image
   type: boolean
   show_subquestion_if: false
   group: "Container Images"
   subquestions:
-  - variable: engine.image.repository
+  - variable: gateway.image.repository
-    default: "quay.io/submariner/submariner"
+    default: "quay.io/submariner/submariner-gateway"
-    description: "Submariner Engine Image Repository"
+    description: "Submariner Gateway Image Repository"
     type: string
-    label: Submariner Engine Image Repository
+    label: Submariner Gateway Image Repository
-  - variable: engine.image.tag
+  - variable: gateway.image.tag
     default: "0.6.0"
-    description: "Submariner Engine Image Tag"
+    description: "Submariner Gateway Image Tag"
     type: string
-    label: Submariner Engine Image Tag
+    label: Submariner Gateway Image Tag
 - variable: defaultRouteAgentImage
   default: true
   description: "Use default Submariner Route Agent image or specify a custom one"
@@ -35,7 +35,7 @@ questions:
     description: "Submariner Route Agent Image Tag"
     type: string
     label: Submariner Route Agent Image Tag
-- variable: engine.nodeSelectorEnabled
+- variable: gateway.nodeSelectorEnabled
   default: true
   description: "Restrict submariner to nodes labeled with submariner.io/gateway=true"
   label: Restrict gateway deployments to specific nodes

submariner/templates/NOTES.txt

@@ -1,6 +1,6 @@
 Submariner is now installed.
 
-{{- if .Values.engine.nodeSelectorEnabled }}
+{{- if .Values.gateway.nodeSelectorEnabled }}
 If you haven't done so yet, please label a node as `submariner.io/gateway=true` to elect it for running Submariner.
 {{- end }}
 

submariner/templates/_helpers.tpl

@@ -32,13 +32,13 @@ Create chart name and version as used by the chart label.
 {{- end -}}
 
 {{/*
-Create the name of the submariner-engine service account to use
+Create the name of the submariner-gateway service account to use
 */}}
-{{- define "submariner.engineServiceAccountName" -}}
+{{- define "submariner.gatewayServiceAccountName" -}}
-{{- if .Values.serviceAccounts.engine.create -}}
+{{- if .Values.serviceAccounts.gateway.create -}}
-    {{ default "submariner-engine" .Values.serviceAccounts.engine.name }}
+    {{ default "submariner-gateway" .Values.serviceAccounts.gateway.name }}
 {{- else -}}
-    {{ default "default" .Values.serviceAccounts.engine.name }}
+    {{ default "default" .Values.serviceAccounts.gateway.name }}
 {{- end -}}
 {{- end -}}
 

submariner/templates/engine-deploy.yaml

@@ -5,14 +5,14 @@ metadata:
     heritage: {{ .Release.Service | quote }}
     release: {{ .Release.Name | quote }}
     chart: {{ template "submariner.chart" . }}
-    app: {{ template "submariner.fullname" . }}-engine
+    app: {{ template "submariner.fullname" . }}-gateway
-    component: engine
+    component: gateway
   name: {{ template "submariner.fullname" . }}-gateway
 spec:
   revisionHistoryLimit: 5
   selector:
     matchLabels:
-      app: {{ template "submariner.fullname" . }}-engine
+      app: {{ template "submariner.fullname" . }}-gateway
   updateStrategy:
     rollingUpdate:
       maxUnavailable: 1
@@ -21,7 +21,7 @@ spec:
     metadata:
       creationTimestamp: null
       labels:
-        app: {{ template "submariner.fullname" . }}-engine
+        app: {{ template "submariner.fullname" . }}-gateway
     spec:
       affinity:
         podAntiAffinity:
@@ -31,19 +31,19 @@ spec:
               - key: app
                 operator: In
                 values:
-                - {{ template "submariner.fullname" . }}-engine
+                - {{ template "submariner.fullname" . }}-gateway
             topologyKey: "kubernetes.io/hostname"
-{{- with .Values.engine.affinity }}
+{{- with .Values.gateway.affinity }}
 {{ toYaml . | indent 8 }}
 {{- end }}
       nodeSelector:
-{{- if .Values.engine.nodeSelectorEnabled }}
+{{- if .Values.gateway.nodeSelectorEnabled }}
         submariner.io/gateway: "true"
 {{- end }}
-{{- with .Values.engine.nodeSelector }}
+{{- with .Values.gateway.nodeSelector }}
 {{ toYaml . | indent 8 }}
 {{- end }}
-{{- with .Values.engine.tolerations }}
+{{- with .Values.gateway.tolerations }}
       tolerations:
 {{ toYaml . | indent 8 }}
 {{- end }}
@@ -112,11 +112,11 @@ spec:
           valueFrom:
             fieldRef:
               fieldPath: "spec.nodeName"
-        image: {{ .Values.engine.image.repository }}:{{ default .Chart.AppVersion .Values.engine.image.tag }}
+        image: {{ .Values.gateway.image.repository }}:{{ default .Chart.AppVersion .Values.gateway.image.tag }}
-        imagePullPolicy: {{ .Values.engine.image.pullPolicy }}
+        imagePullPolicy: {{ .Values.gateway.image.pullPolicy }}
         name: submariner
         resources:
-{{ toYaml .Values.engine.resources | indent 10 }}
+{{ toYaml .Values.gateway.resources | indent 10 }}
         securityContext:
           allowPrivilegeEscalation: true
           capabilities:
@@ -135,4 +135,4 @@ spec:
       schedulerName: default-scheduler
       securityContext: {}
       terminationGracePeriodSeconds: 1
-      serviceAccountName: {{ template "submariner.engineServiceAccountName" . }}
+      serviceAccountName: {{ template "submariner.gatewayServiceAccountName" . }}

submariner/templates/rbac.yaml

@@ -2,7 +2,7 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:
-  name: {{ template "submariner.fullname" . }}:engine
+  name: {{ template "submariner.fullname" . }}:gateway
   labels:
     heritage: {{ .Release.Service | quote }}
     release: {{ .Release.Name | quote }}
@@ -82,7 +82,7 @@ rules:
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
-  name: {{ template "submariner.fullname" . }}:engine
+  name: {{ template "submariner.fullname" . }}:gateway
   labels:
     heritage: {{ .Release.Service | quote }}
     release: {{ .Release.Name | quote }}
@@ -91,10 +91,10 @@ metadata:
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: Role
-  name: {{ template "submariner.fullname" . }}:engine
+  name: {{ template "submariner.fullname" . }}:gateway
 subjects:
   - kind: ServiceAccount
-    name: {{ template "submariner.engineServiceAccountName" . }}
+    name: {{ template "submariner.gatewayServiceAccountName" . }}
     namespace: {{ .Release.Namespace }}
 ---
 apiVersion: rbac.authorization.k8s.io/v1
@@ -299,7 +299,7 @@ subjects:
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
-  name: {{ template "submariner.fullname" . }}:engine
+  name: {{ template "submariner.fullname" . }}:gateway
   labels:
     heritage: {{ .Release.Service | quote }}
     release: {{ .Release.Name | quote }}
@@ -366,7 +366,7 @@ rules:
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
-  name: {{ template "submariner.fullname" . }}:engine
+  name: {{ template "submariner.fullname" . }}:gateway
   labels:
     heritage: {{ .Release.Service | quote }}
     release: {{ .Release.Name | quote }}
@@ -375,10 +375,10 @@ metadata:
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: ClusterRole
-  name: {{ template "submariner.fullname" . }}:engine
+  name: {{ template "submariner.fullname" . }}:gateway
 subjects:
   - kind: ServiceAccount
-    name: {{ template "submariner.engineServiceAccountName" . }}
+    name: {{ template "submariner.gatewayServiceAccountName" . }}
     namespace: {{ .Release.Namespace }}
 ---
 apiVersion: rbac.authorization.k8s.io/v1

submariner/templates/svc-acct.yaml

@@ -1,8 +1,8 @@
-{{- if .Values.serviceAccounts.engine.create }}
+{{- if .Values.serviceAccounts.gateway.create }}
 apiVersion: v1
 kind: ServiceAccount
 metadata:
-  name: {{ template "submariner.engineServiceAccountName" . }}
+  name: {{ template "submariner.gatewayServiceAccountName" . }}
   labels:
     heritage: {{ .Release.Service | quote }}
     release: {{ .Release.Name | quote }}

submariner/values.yaml

@@ -29,9 +29,9 @@ leadership:
   leaseDuration: 10
   renewDeadline: 5
   retryPeriod: 2
-engine:
+gateway:
   image:
-    repository: quay.io/submariner/submariner
+    repository: quay.io/submariner/submariner-gateway
     tag: ""
     pullPolicy: IfNotPresent
   resources: {}
@@ -65,7 +65,7 @@ lighthouseCoredns:
     tag: ""
     pullPolicy: IfNotPresent
 serviceAccounts:
-  engine:
+  gateway:
     create: true
     name: ""
   routeAgent: