From 102f4252591fb0a211756856da1b07af07623d93 Mon Sep 17 00:00:00 2001 From: ITQ Date: Thu, 12 Feb 2026 20:52:18 +0300 Subject: [PATCH] chore(backend/api): naming improvements --- src/backend/api/v1/auth/endpoints.py | 6 +++--- src/backend/api/v1/reviews/endpoints.py | 22 +++++++++++----------- src/backend/api/v1/users/endpoints.py | 12 ++++++------ 3 files changed, 20 insertions(+), 20 deletions(-) diff --git a/src/backend/api/v1/auth/endpoints.py b/src/backend/api/v1/auth/endpoints.py index c0b421b..e00defa 100644 --- a/src/backend/api/v1/auth/endpoints.py +++ b/src/backend/api/v1/auth/endpoints.py @@ -36,7 +36,7 @@ router = Router(tags=["auth"]) def login( request: HttpRequest, payload: LoginIn, -) -> tuple[int, TokenPairOut]: +) -> tuple[HTTPStatus, TokenPairOut]: user = authenticate( request, username=payload.username, @@ -66,7 +66,7 @@ def login( def refresh( request: HttpRequest, payload: TokenRefreshIn, -) -> tuple[int, TokenRefreshOut]: +) -> tuple[HTTPStatus, TokenRefreshOut]: try: claims = decode_refresh_token(payload.refresh) except TokenError: @@ -93,7 +93,7 @@ def refresh( summary="Current user profile", description="Return the profile of the currently authenticated user.", ) -def me(request: HttpRequest) -> tuple[int, MeOut]: +def me(request: HttpRequest) -> tuple[HTTPStatus, MeOut]: user = getattr(request, "auth", None) if not isinstance(user, User): raise AuthenticationError diff --git a/src/backend/api/v1/reviews/endpoints.py b/src/backend/api/v1/reviews/endpoints.py index 83c49cb..444702a 100644 --- a/src/backend/api/v1/reviews/endpoints.py +++ b/src/backend/api/v1/reviews/endpoints.py @@ -51,7 +51,7 @@ def list_approver_groups( request: HttpRequest, limit: int = 50, offset: int = 0, -) -> tuple[int, ApproverGroupListOut]: +) -> tuple[HTTPStatus, ApproverGroupListOut]: qs = approver_group_list() total = qs.count() items = [ @@ -75,7 +75,7 @@ def list_approver_groups( def create_approver_group( request: HttpRequest, payload: ApproverGroupCreateIn, -) -> tuple[int, ApproverGroupOut]: +) -> tuple[HTTPStatus, ApproverGroupOut]: experimenter = get_object_or_404(User, pk=payload.experimenter_id) group = approver_group_create( @@ -102,7 +102,7 @@ def create_approver_group( def get_approver_group( request: HttpRequest, group_id: str, -) -> tuple[int, ApproverGroupOut]: +) -> tuple[HTTPStatus, ApproverGroupOut]: group = get_object_or_404( ApproverGroup.objects.select_related("experimenter").prefetch_related( "approvers" @@ -126,7 +126,7 @@ def update_approver_group( request: HttpRequest, group_id: str, payload: ApproverGroupUpdateIn, -) -> tuple[int, ApproverGroupOut]: +) -> tuple[HTTPStatus, ApproverGroupOut]: group = get_object_or_404( ApproverGroup.objects.select_related("experimenter").prefetch_related( "approvers" @@ -161,7 +161,7 @@ def update_approver_group( def delete_approver_group( request: HttpRequest, group_id: str, -) -> tuple[int, None]: +) -> tuple[HTTPStatus, None]: group = get_object_or_404( ApproverGroup.objects.select_related("experimenter").prefetch_related( "approvers" @@ -186,7 +186,7 @@ def add_approver_to_group( request: HttpRequest, group_id: str, payload: ApproverGroupAddApproverIn, -) -> tuple[int, ApproverGroupOut]: +) -> tuple[HTTPStatus, ApproverGroupOut]: group = get_object_or_404( ApproverGroup.objects.select_related("experimenter").prefetch_related( "approvers" @@ -220,7 +220,7 @@ def remove_approver_from_group( request: HttpRequest, group_id: str, payload: ApproverGroupRemoveApproverIn, -) -> tuple[int, ApproverGroupOut]: +) -> tuple[HTTPStatus, ApproverGroupOut]: group = get_object_or_404( ApproverGroup.objects.select_related("experimenter").prefetch_related( "approvers" @@ -253,7 +253,7 @@ def remove_approver_from_group( def get_approver_group_by_experimenter( request: HttpRequest, experimenter_id: str, -) -> tuple[int, ApproverGroupOut]: +) -> tuple[HTTPStatus, ApproverGroupOut]: group = approver_group_get_by_experimenter_id(experimenter_id) if group is None: raise Http404 @@ -272,7 +272,7 @@ def get_approver_group_by_experimenter( ) def get_review_settings( request: HttpRequest, -) -> tuple[int, ReviewSettingsOut]: +) -> tuple[HTTPStatus, ReviewSettingsOut]: settings = review_settings_load() return HTTPStatus.OK, ReviewSettingsOut.model_validate(settings) @@ -290,7 +290,7 @@ def get_review_settings( def update_review_settings( request: HttpRequest, payload: ReviewSettingsUpdateIn, -) -> tuple[int, ReviewSettingsOut]: +) -> tuple[HTTPStatus, ReviewSettingsOut]: settings = review_settings_update( default_min_approvals=payload.default_min_approvals, allow_any_approver=payload.allow_any_approver, @@ -312,7 +312,7 @@ def update_review_settings( def get_effective_policy( request: HttpRequest, experimenter_id: str, -) -> tuple[int, EffectiveReviewPolicyOut]: +) -> tuple[HTTPStatus, EffectiveReviewPolicyOut]: experimenter = get_object_or_404(User, pk=experimenter_id) if experimenter.role != UserRole.EXPERIMENTER: diff --git a/src/backend/api/v1/users/endpoints.py b/src/backend/api/v1/users/endpoints.py index e014bf3..164c2af 100644 --- a/src/backend/api/v1/users/endpoints.py +++ b/src/backend/api/v1/users/endpoints.py @@ -42,7 +42,7 @@ def list_users( search: str | None = None, limit: int = 50, offset: int = 0, -) -> tuple[int, UserListOut]: +) -> tuple[HTTPStatus, UserListOut]: qs = user_list(role=role, is_active=is_active, search=search) total = qs.count() items = [ @@ -65,7 +65,7 @@ def list_users( def create_user( request: HttpRequest, payload: UserCreateIn, -) -> tuple[int, UserOut]: +) -> tuple[HTTPStatus, UserOut]: valid_roles = {choice[0] for choice in UserRole.choices} if payload.role not in valid_roles: raise ValidationError( @@ -100,7 +100,7 @@ def create_user( def get_user( request: HttpRequest, user_id: str, -) -> tuple[int, UserOut]: +) -> tuple[HTTPStatus, UserOut]: user = get_object_or_404(User, pk=user_id) return HTTPStatus.OK, UserOut.model_validate(user) @@ -120,7 +120,7 @@ def update_user( request: HttpRequest, user_id: str, payload: UserUpdateIn, -) -> tuple[int, UserOut]: +) -> tuple[HTTPStatus, UserOut]: user = get_object_or_404(User, pk=user_id) if payload.role is not None: @@ -159,7 +159,7 @@ def update_user( def delete_user( request: HttpRequest, user_id: str, -) -> tuple[int, None]: +) -> tuple[HTTPStatus, None]: user = get_object_or_404(User, pk=user_id) current_user = getattr(request, "auth", None) @@ -185,7 +185,7 @@ def assign_role( request: HttpRequest, user_id: str, payload: UserRoleAssignIn, -) -> tuple[int, UserOut]: +) -> tuple[HTTPStatus, UserOut]: user = get_object_or_404(User, pk=user_id) updated_user = user_assign_role(user=user, role=payload.role)