chore(): minor fixes around codebase
This commit is contained in:
@@ -5,7 +5,6 @@ from django.http import Http404, HttpRequest
|
||||
from ninja import Router
|
||||
from prometheus_client import Counter
|
||||
|
||||
from api.v1.auth.endpoints import jwt_bearer
|
||||
from api.v1.events.schemas import (
|
||||
EventErrorOut,
|
||||
EventTypeCreateIn,
|
||||
@@ -21,6 +20,7 @@ from apps.events.services import (
|
||||
event_type_update,
|
||||
process_events_batch,
|
||||
)
|
||||
from apps.users.auth.bearer import jwt_bearer
|
||||
|
||||
EVENTS_INGESTED = Counter(
|
||||
"lotty_events_ingested_total",
|
||||
@@ -62,9 +62,7 @@ def list_event_types(
|
||||
is_active: bool | None = None, # noqa: FBT001
|
||||
) -> tuple[int, list[EventTypeOut]]:
|
||||
qs = event_type_list(is_active=is_active)
|
||||
return HTTPStatus.OK, [
|
||||
EventTypeOut.model_validate(metric) for metric in qs
|
||||
]
|
||||
return HTTPStatus.OK, [EventTypeOut.model_validate(et) for et in qs]
|
||||
|
||||
|
||||
@router.get(
|
||||
|
||||
@@ -132,7 +132,7 @@ def create_rule(
|
||||
try:
|
||||
experiment = Experiment.objects.get(pk=payload.experiment_id)
|
||||
except Experiment.DoesNotExist:
|
||||
raise Http404 from Experiment.DoesNotExist
|
||||
raise Http404 from None
|
||||
|
||||
r = rule_create(
|
||||
event_type=payload.event_type,
|
||||
|
||||
@@ -1,14 +1,15 @@
|
||||
from http import HTTPStatus
|
||||
from uuid import UUID
|
||||
|
||||
from django.core.exceptions import ValidationError
|
||||
from django.http import Http404, HttpRequest
|
||||
from django.utils.dateparse import parse_datetime
|
||||
from ninja import Router
|
||||
|
||||
from api.v1.auth.endpoints import jwt_bearer
|
||||
from api.v1.reports.schemas import ExperimentReportOut
|
||||
from apps.experiments.models import Experiment
|
||||
from apps.reports.services import build_experiment_report
|
||||
from apps.users.auth.bearer import jwt_bearer
|
||||
|
||||
router = Router(tags=["reports"], auth=jwt_bearer)
|
||||
|
||||
@@ -34,11 +35,15 @@ def get_experiment_report(
|
||||
if start_date:
|
||||
parsed_start = parse_datetime(start_date)
|
||||
if parsed_start is None:
|
||||
raise Http404
|
||||
raise ValidationError(
|
||||
{"start_date": "Must be a valid ISO 8601 datetime."}
|
||||
)
|
||||
if end_date:
|
||||
parsed_end = parse_datetime(end_date)
|
||||
if parsed_end is None:
|
||||
raise Http404
|
||||
raise ValidationError(
|
||||
{"end_date": "Must be a valid ISO 8601 datetime."}
|
||||
)
|
||||
|
||||
report_data = build_experiment_report(
|
||||
experiment=experiment,
|
||||
|
||||
@@ -247,7 +247,7 @@ def remove_approver_from_group(
|
||||
description=(
|
||||
"Retrieve the approver group assigned to a specific experimenter. "
|
||||
"Returns 404 if no explicit group exists. "
|
||||
"Available to any authenticated user."
|
||||
"Admin only."
|
||||
),
|
||||
)
|
||||
@require_admin
|
||||
|
||||
Reference in New Issue
Block a user