PROD.2026/Lotty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(): test and validation improvements

Browse Source
This commit is contained in:
ITQ
2026-02-13 10:39:11 +03:00
parent 9c45d9883e
commit 94d99c72e6
12 changed files with 96 additions and 177 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/backend/api/v1/reviews/schemas.py
+2
View File
@@ -27,6 +27,8 @@ class ExperimenterOut(ModelSchema):
User.id.field.name,
User.username.field.name,
User.email.field.name,
User.first_name.field.name,
User.last_name.field.name,
)
src/backend/api/v1/reviews/tests/test_reviews_api.py
+9 -9
View File
@@ -162,7 +162,7 @@ class ApproverGroupAPITest(TestCase):
content_type="application/json",
HTTP_AUTHORIZATION=self.admin_auth,
)
self.assertIn(resp.status_code, [422, 400])
self.assertEqual(resp.status_code, 422)
def test_create_group_duplicate_raises(self) -> None:
self.client.post(
@@ -187,7 +187,7 @@ class ApproverGroupAPITest(TestCase):
content_type="application/json",
HTTP_AUTHORIZATION=self.admin_auth,
)
self.assertIn(resp.status_code, [422, 400, 409])
self.assertEqual(resp.status_code, 409)
def test_create_group_approver_wrong_role(self) -> None:
resp = self.client.post(
@@ -202,7 +202,7 @@ class ApproverGroupAPITest(TestCase):
content_type="application/json",
HTTP_AUTHORIZATION=self.admin_auth,
)
self.assertIn(resp.status_code, [422, 400])
self.assertEqual(resp.status_code, 422)
def testget_group_admin(self) -> None:
group: ApproverGroup = approver_group_create(
@@ -416,7 +416,7 @@ class ApproverGroupAPITest(TestCase):
content_type="application/json",
HTTP_AUTHORIZATION=self.admin_auth,
)
self.assertIn(resp.status_code, [422, 400])
self.assertEqual(resp.status_code, 422)
def test_add_approver_duplicate(self) -> None:
group: ApproverGroup = approver_group_create(
@@ -432,7 +432,7 @@ class ApproverGroupAPITest(TestCase):
content_type="application/json",
HTTP_AUTHORIZATION=self.admin_auth,
)
self.assertIn(resp.status_code, [422, 400])
self.assertEqual(resp.status_code, 422)
def test_add_approver_viewer_denied(self) -> None:
group: ApproverGroup = approver_group_create(
@@ -485,7 +485,7 @@ class ApproverGroupAPITest(TestCase):
content_type="application/json",
HTTP_AUTHORIZATION=self.admin_auth,
)
self.assertIn(resp.status_code, [422, 400])
self.assertEqual(resp.status_code, 422)
def test_remove_approver_not_in_group(self) -> None:
group: ApproverGroup = approver_group_create(
@@ -501,7 +501,7 @@ class ApproverGroupAPITest(TestCase):
content_type="application/json",
HTTP_AUTHORIZATION=self.admin_auth,
)
self.assertIn(resp.status_code, [422, 400])
self.assertEqual(resp.status_code, 422)
def test_remove_approver_viewer_denied(self) -> None:
group: ApproverGroup = approver_group_create(
@@ -672,7 +672,7 @@ class ReviewSettingsAPITest(TestCase):
content_type="application/json",
HTTP_AUTHORIZATION=self.admin_auth,
)
self.assertIn(resp.status_code, [422, 400])
self.assertEqual(resp.status_code, 422)
class EffectivePolicyAPITest(TestCase):
@@ -749,7 +749,7 @@ class EffectivePolicyAPITest(TestCase):
),
HTTP_AUTHORIZATION=self.admin_auth,
)
self.assertIn(resp.status_code, [422, 400])
self.assertEqual(resp.status_code, 422)
def test_effective_policy_nonexistent_user(self) -> None:
resp = self.client.get(