refactor(); project refactor
This commit is contained in:
@@ -4,6 +4,7 @@ from typing import Any
|
||||
from django.core.exceptions import ValidationError
|
||||
from django.db import transaction
|
||||
|
||||
from apps.conflicts.services import validate_domain_conflicts
|
||||
from apps.experiments.models import (
|
||||
ACTIVE_STATUSES,
|
||||
ALLOWED_TRANSITIONS,
|
||||
@@ -16,7 +17,6 @@ from apps.experiments.models import (
|
||||
OutcomeType,
|
||||
Variant,
|
||||
)
|
||||
from apps.conflicts.services import validate_domain_conflicts
|
||||
from apps.flags.models import FeatureFlag, validate_value_for_type
|
||||
from apps.notifications.services import (
|
||||
NotificationPayload,
|
||||
@@ -30,12 +30,19 @@ from apps.users.models import User
|
||||
from config.errors import ForbiddenError
|
||||
|
||||
|
||||
def _notify(event_type: str, experiment: Experiment, extra: dict[str, Any] | None = None) -> None:
|
||||
def _notify(
|
||||
event_type: str,
|
||||
experiment: Experiment,
|
||||
extra: dict[str, Any] | None = None,
|
||||
) -> None:
|
||||
notification_enqueue(
|
||||
event_type,
|
||||
NotificationPayload(
|
||||
title=f"{event_type.replace('_', ' ').title()}",
|
||||
body=f"Experiment '{experiment.name}' — {event_type.replace('_', ' ')}.",
|
||||
body=(
|
||||
f"Experiment '{experiment.name}' — "
|
||||
f"{event_type.replace('_', ' ')}."
|
||||
),
|
||||
event_type=event_type,
|
||||
experiment_id=str(experiment.pk),
|
||||
experiment_name=experiment.name,
|
||||
|
||||
@@ -14,7 +14,6 @@ from apps.experiments.models import (
|
||||
OutcomeType,
|
||||
)
|
||||
from apps.experiments.services import (
|
||||
ensure_owner_or_admin,
|
||||
experiment_approve,
|
||||
experiment_archive,
|
||||
experiment_complete,
|
||||
@@ -530,9 +529,7 @@ class OwnershipPermissionTest(TestCase):
|
||||
|
||||
def test_other_experimenter_cannot_submit_for_review(self) -> None:
|
||||
with self.assertRaises(ForbiddenError):
|
||||
experiment_submit_for_review(
|
||||
experiment=self.exp, user=self.other
|
||||
)
|
||||
experiment_submit_for_review(experiment=self.exp, user=self.other)
|
||||
|
||||
def test_admin_can_submit_for_review(self) -> None:
|
||||
exp = experiment_submit_for_review(
|
||||
|
||||
Reference in New Issue
Block a user