PROD.2026/Lotty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(): small improvements

Browse Source
This commit is contained in:
ITQ
2026-02-23 23:29:03 +03:00
parent 85bed92364
commit ffd887dc39
11 changed files with 197 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/backend/apps/conflicts/tests/test_conflicts.py
+24 -8
View File
@@ -285,7 +285,7 @@ class ResolveDomainConflictTest(TestCase):
exp = experiment_approve(experiment=exp, approver=self.approver)
return experiment_start(experiment=exp, user=self.experimenter)
def test_mutual_exclusion_winner_is_first(self) -> None:
def test_mutual_exclusion_deterministic_per_subject(self) -> None:
domain = make_domain(
suffix="_me",
policy=ConflictPolicy.MUTUAL_EXCLUSION,
@@ -293,10 +293,17 @@ class ResolveDomainConflictTest(TestCase):
)
exp1 = self._make_and_start("_me1", domain)
exp2 = self._make_and_start("_me2", domain)
winner = resolve_domain_conflict(exp1.pk, domain.pk, "u1")
self.assertTrue(winner)
loser = resolve_domain_conflict(exp2.pk, domain.pk, "u1")
self.assertFalse(loser)
exp1_u1 = resolve_domain_conflict(exp1.pk, domain.pk, "u1")
exp2_u1 = resolve_domain_conflict(exp2.pk, domain.pk, "u1")
self.assertNotEqual(exp1_u1, exp2_u1)
self.assertEqual(
exp1_u1,
resolve_domain_conflict(exp1.pk, domain.pk, "u1"),
)
self.assertEqual(
exp2_u1,
resolve_domain_conflict(exp2.pk, domain.pk, "u1"),
)
def test_priority_higher_wins(self) -> None:
domain = make_domain(
@@ -309,7 +316,7 @@ class ResolveDomainConflictTest(TestCase):
self.assertTrue(resolve_domain_conflict(exp_high.pk, domain.pk, "u1"))
self.assertFalse(resolve_domain_conflict(exp_low.pk, domain.pk, "u1"))
def test_priority_tie_first_created_wins(self) -> None:
def test_priority_tie_deterministic_per_subject(self) -> None:
domain = make_domain(
suffix="_tie",
policy=ConflictPolicy.PRIORITY,
@@ -317,8 +324,17 @@ class ResolveDomainConflictTest(TestCase):
)
exp1 = self._make_and_start("_tie1", domain, priority=5)
exp2 = self._make_and_start("_tie2", domain, priority=5)
self.assertTrue(resolve_domain_conflict(exp1.pk, domain.pk, "u1"))
self.assertFalse(resolve_domain_conflict(exp2.pk, domain.pk, "u1"))
exp1_u1 = resolve_domain_conflict(exp1.pk, domain.pk, "u1")
exp2_u1 = resolve_domain_conflict(exp2.pk, domain.pk, "u1")
self.assertNotEqual(exp1_u1, exp2_u1)
self.assertEqual(
exp1_u1,
resolve_domain_conflict(exp1.pk, domain.pk, "u1"),
)
self.assertEqual(
exp2_u1,
resolve_domain_conflict(exp2.pk, domain.pk, "u1"),
)
def test_single_experiment_always_wins(self) -> None:
domain = make_domain(suffix="_single")