From d990e1e0deed51074166b4f87f8c349bddf261b5 Mon Sep 17 00:00:00 2001 From: MaximOksiuta <63787095+MaximOksiuta@users.noreply.github.com> Date: Sun, 23 Nov 2025 15:35:39 +0300 Subject: [PATCH] tests fixed # Conflicts: # app/src/test/java/com/prodhack/moscow2025/domain/usecase/GetDefaultPhoneNumberPatternUseCaseTest.kt --- .../usecase/GetDefaultPhoneNumberPatternUseCaseTest.kt | 10 ++++++---- .../presentation/utils/PhoneTransformationTest.kt | 4 +--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/src/test/java/com/prodhack/moscow2025/domain/usecase/GetDefaultPhoneNumberPatternUseCaseTest.kt b/app/src/test/java/com/prodhack/moscow2025/domain/usecase/GetDefaultPhoneNumberPatternUseCaseTest.kt index 91c34f3..5a4b880 100644 --- a/app/src/test/java/com/prodhack/moscow2025/domain/usecase/GetDefaultPhoneNumberPatternUseCaseTest.kt +++ b/app/src/test/java/com/prodhack/moscow2025/domain/usecase/GetDefaultPhoneNumberPatternUseCaseTest.kt @@ -1,8 +1,10 @@ package com.prodhack.moscow2025.domain.usecase import com.prodhack.moscow2025.data.data_providers.PhoneNumberPatternsProvider +import org.junit.Assert.assertEquals +import org.junit.Assert.assertNotNull +import org.junit.Assert.assertTrue import org.junit.Test -import org.junit.Assert.* import java.util.Locale class GetDefaultPhoneNumberPatternUseCaseTest { @@ -13,7 +15,7 @@ class GetDefaultPhoneNumberPatternUseCaseTest { // In a real scenario, you'd mock Locale.getDefault() val useCase = GetDefaultPhoneNumberPatternUseCase() val result = useCase.execute() - + // If system locale is RU, should return Russian pattern if (Locale.getDefault().country.equals("RU", ignoreCase = true)) { assertNotNull(result) @@ -40,7 +42,7 @@ class GetDefaultPhoneNumberPatternUseCaseTest { it.countryCodeISO.equals(systemLocale, ignoreCase = true) } // This is acceptable - not all locales may have patterns - assertTrue(true) + assertTrue(hasPatternForLocale) } } @@ -62,7 +64,7 @@ class GetDefaultPhoneNumberPatternUseCaseTest { // This is tested implicitly through the implementation val result = useCase.execute() // Should not crash regardless of locale case - assertNotNull(useCase) + assertNotNull(result) } } diff --git a/app/src/test/java/com/prodhack/moscow2025/presentation/utils/PhoneTransformationTest.kt b/app/src/test/java/com/prodhack/moscow2025/presentation/utils/PhoneTransformationTest.kt index d063a7d..18c5236 100644 --- a/app/src/test/java/com/prodhack/moscow2025/presentation/utils/PhoneTransformationTest.kt +++ b/app/src/test/java/com/prodhack/moscow2025/presentation/utils/PhoneTransformationTest.kt @@ -69,8 +69,6 @@ class PhoneTransformationTest { val input = AnnotatedString("12345678901234567890") // Longer than mask val result = transformation.filter(input) assertNotNull(result) - // Should be limited to maxLength - val maxLength = "(000) 000-0000".count { it == '0' } assertTrue(result.text.text.length <= "(000) 000-0000".length) } @@ -79,7 +77,7 @@ class PhoneTransformationTest { val transformation1 = PhoneVisualTransformation(mask = "(000) 000-0000", maskNumber = '0') val transformation2 = PhoneVisualTransformation(mask = "(000) 000-0000", maskNumber = '0') val transformation3 = PhoneVisualTransformation(mask = "000-0000", maskNumber = '0') - + assertEquals(transformation1, transformation2) assertNotEquals(transformation1, transformation3) }