feat: spring tests #17

2026-04-20T21:20:19Z

glashark commented

2026-04-20 21:20:19 +00:00

(Migrated from github.com)

Summary by CodeRabbit

New Features
- Search films by title using the new search endpoint
- View available films to add to your library (excludes films already in your collection)
Tests
- Added comprehensive test coverage for film search, creation, and deletion operations
- Added test coverage for library management functionality
- Added test coverage for user management operations

## Summary by CodeRabbit * **New Features** * Search films by title using the new search endpoint * View available films to add to your library (excludes films already in your collection) * **Tests** * Added comprehensive test coverage for film search, creation, and deletion operations * Added test coverage for library management functionality * Added test coverage for user management operations

coderabbitai[bot] commented

2026-04-20 21:20:27 +00:00

(Migrated from github.com)

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Free

Run ID: d85b1be3-bbb9-4c2e-b718-e5ceacbd6726

📥 Commits

Reviewing files that changed from the base of the PR and between 482b282dd5 and 8926e5b08c.

📒 Files selected for processing (8)

src/main/kotlin/com/project/movienight/adapters/persistence/jdbc/FilmRepository.kt
src/main/kotlin/com/project/movienight/adapters/web/FilmController.kt
src/main/kotlin/com/project/movienight/adapters/web/FilmLibraryController.kt
src/main/kotlin/com/project/movienight/application/ports/output/FilmRepositoryPort.kt
src/main/kotlin/com/project/movienight/application/services/FilmService.kt
src/test/kotlin/com/project/movienight/controllers/FilmControllerTest.kt
src/test/kotlin/com/project/movienight/controllers/FilmLibraryControllerTest.kt
src/test/kotlin/com/project/movienight/controllers/UserControllerTest.kt

📝 Walkthrough

Walkthrough

This PR implements a title-based film search feature across the persistence, service, and web layers. It adds a findByTitle method to the repository port and implementation, exposes findByTitle and findAll methods through FilmService, and introduces two new HTTP GET endpoints: /api/films/search for searching films by title and /api/users/{userId}/library/available-films for retrieving available films in a user's library. Comprehensive integration tests are included.

Changes

Cohort / File(s)	Summary
Persistence Layer `src/main/kotlin/com/project/movienight/adapters/persistence/jdbc/FilmRepository.kt`, `src/main/kotlin/com/project/movienight/application/ports/output/FilmRepositoryPort.kt`	Added `findByTitle(title: String): Film?` method to repository port interface and implemented with parameterized SQL query against the `films` table filtering by title and returning first match or null.
Service Layer `src/main/kotlin/com/project/movienight/application/services/FilmService.kt`	Added two delegation methods: `findByTitle(title: String): Film?` and `findAll(): List<Film>`, both passing through to the repository layer.
Web Layer `src/main/kotlin/com/project/movienight/adapters/web/FilmController.kt`, `src/main/kotlin/com/project/movienight/adapters/web/FilmLibraryController.kt`	Introduced `GET /api/films/search` endpoint accepting `title` query parameter with optional result. Added `GET /api/users/{userId}/library/available-films` endpoint retrieving available films for user's library by filtering out already-added films. Both controllers now depend on `FilmService`.
Integration Tests `src/test/kotlin/com/project/movienight/controllers/FilmControllerTest.kt`, `src/test/kotlin/com/project/movienight/controllers/FilmLibraryControllerTest.kt`, `src/test/kotlin/com/project/movienight/controllers/UserControllerTest.kt`	Added comprehensive Spring Boot integration test classes covering film CRUD operations, title-based search with existing and non-existent films, user CRUD operations, and film library management operations (add/remove films).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 Whiskers twitch with search delight,
Films by title, shining bright,
Libraries find what's free to claim,
New endpoints dance with test acclaim,
Delegation flows from depth to height! 🎬

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

<details> <summary>ℹ️ Recent review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: Organization UI **Review profile**: ASSERTIVE **Plan**: Free **Run ID**: `d85b1be3-bbb9-4c2e-b718-e5ceacbd6726` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 482b282dd5c1498f488fdcca1d46ec45a22bcbb6 and 8926e5b08c95fc5a475d5143988d92bff4188c7a. </details> <details> <summary>📒 Files selected for processing (8)</summary> * `src/main/kotlin/com/project/movienight/adapters/persistence/jdbc/FilmRepository.kt` * `src/main/kotlin/com/project/movienight/adapters/web/FilmController.kt` * `src/main/kotlin/com/project/movienight/adapters/web/FilmLibraryController.kt` * `src/main/kotlin/com/project/movienight/application/ports/output/FilmRepositoryPort.kt` * `src/main/kotlin/com/project/movienight/application/services/FilmService.kt` * `src/test/kotlin/com/project/movienight/controllers/FilmControllerTest.kt` * `src/test/kotlin/com/project/movienight/controllers/FilmLibraryControllerTest.kt` * `src/test/kotlin/com/project/movienight/controllers/UserControllerTest.kt` </details> </details> ---  <details> <summary>📝 Walkthrough</summary> ## Walkthrough This PR implements a title-based film search feature across the persistence, service, and web layers. It adds a `findByTitle` method to the repository port and implementation, exposes `findByTitle` and `findAll` methods through `FilmService`, and introduces two new HTTP GET endpoints: `/api/films/search` for searching films by title and `/api/users/{userId}/library/available-films` for retrieving available films in a user's library. Comprehensive integration tests are included. ## Changes |Cohort / File(s)|Summary| |---|---| |**Persistence Layer** `src/main/kotlin/com/project/movienight/adapters/persistence/jdbc/FilmRepository.kt`, `src/main/kotlin/com/project/movienight/application/ports/output/FilmRepositoryPort.kt`|Added `findByTitle(title: String): Film?` method to repository port interface and implemented with parameterized SQL query against the `films` table filtering by title and returning first match or null.| |**Service Layer** `src/main/kotlin/com/project/movienight/application/services/FilmService.kt`|Added two delegation methods: `findByTitle(title: String): Film?` and `findAll(): List<Film>`, both passing through to the repository layer.| |**Web Layer** `src/main/kotlin/com/project/movienight/adapters/web/FilmController.kt`, `src/main/kotlin/com/project/movienight/adapters/web/FilmLibraryController.kt`|Introduced `GET /api/films/search` endpoint accepting `title` query parameter with optional result. Added `GET /api/users/{userId}/library/available-films` endpoint retrieving available films for user's library by filtering out already-added films. Both controllers now depend on `FilmService`.| |**Integration Tests** `src/test/kotlin/com/project/movienight/controllers/FilmControllerTest.kt`, `src/test/kotlin/com/project/movienight/controllers/FilmLibraryControllerTest.kt`, `src/test/kotlin/com/project/movienight/controllers/UserControllerTest.kt`|Added comprehensive Spring Boot integration test classes covering film CRUD operations, title-based search with existing and non-existent films, user CRUD operations, and film library management operations (add/remove films).| ## Estimated code review effort 🎯 3 (Moderate) | ⏱️ ~25 minutes ## Poem > 🐰 Whiskers twitch with search delight, > Films by title, shining bright, > Libraries find what's free to claim, > New endpoints dance with test acclaim, > Delegation flows from depth to height! 🎬 </details>   --- > [!NOTE] > <details> > <summary>🎁 Summarized by CodeRabbit Free</summary> > > Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting <https://app.coderabbit.ai/login>. > > </details> Comment `@coderabbitai help` to get the list of available commands and usage tips.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: ITQ/movienight-backend#17