feat: controllers add missing endpoints #19

Merged
glashark merged 3 commits from feat/controllers-add-missing-endpoints into develop 2026-05-03 12:28:42 +00:00
glashark commented 2026-04-21 10:22:00 +00:00 (Migrated from github.com)
No description provided.
coderabbitai[bot] commented 2026-04-21 10:22:08 +00:00 (Migrated from github.com)

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

βš™οΈ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Free

Run ID: 4ee09c49-6826-48d8-a169-0d663ac7324b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • πŸ” Trigger review

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: skip review by coderabbit.ai --> > [!IMPORTANT] > ## Review skipped > > Auto reviews are disabled on base/target branches other than the default branch. > > > > Please check the settings in the CodeRabbit UI or the `.coderabbit.yaml` file in this repository. To trigger a single review, invoke the `@coderabbitai review` command. > > <details> > <summary>βš™οΈ Run configuration</summary> > > **Configuration used**: Organization UI > > **Review profile**: ASSERTIVE > > **Plan**: Free > > **Run ID**: `4ee09c49-6826-48d8-a169-0d663ac7324b` > > </details> > > You can disable this status message by setting the `reviews.review_status` to `false` in the CodeRabbit configuration file. > > Use the checkbox below for a quick retry: > - [ ] <!-- {"checkboxId": "e9bb8d72-00e8-4f67-9cb2-caf3b22574fe"} --> πŸ” Trigger review <!-- end of auto-generated comment: skip review by coderabbit.ai --> <!-- tips_start --> --- > [!NOTE] > <details> > <summary>🎁 Summarized by CodeRabbit Free</summary> > > Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting <https://app.coderabbit.ai/login>. > > </details> <sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub> <!-- tips_end -->
devitq commented 2026-04-23 06:27:12 +00:00 (Migrated from github.com)

@copilot review

@copilot review
Copilot commented 2026-04-23 06:32:20 +00:00 (Migrated from github.com)

@copilot review

Reviewed the PR changes at 88837d2: no additional code fixes are needed from this comment. I validated branch/workflow status and ran tests locally; current failure is environment-related (tests compiled for Java 21, runner Java 17), not from these controller changes.

> @copilot review > Reviewed the PR changes at `88837d2`: no additional code fixes are needed from this comment. I validated branch/workflow status and ran tests locally; current failure is environment-related (tests compiled for Java 21, runner Java 17), not from these controller changes.
devitq (Migrated from github.com) reviewed 2026-04-23 19:21:11 +00:00
devitq (Migrated from github.com) left a comment

Fix issues described in the comments below

Fix issues described in the comments below
@@ -8,13 +8,18 @@ import com.project.movienight.application.ports.input.CreateFilmUseCase
import com.project.movienight.application.ports.input.DeleteFilmUseCase
devitq (Migrated from github.com) commented 2026-04-23 19:19:49 +00:00

Star projections for imports, again

Star projections for imports, again
@@ -13,4 +17,4 @@
import org.springframework.web.bind.annotation.PatchMapping
import org.springframework.web.bind.annotation.PathVariable
import org.springframework.web.bind.annotation.PostMapping
import org.springframework.web.bind.annotation.RequestBody
devitq (Migrated from github.com) commented 2026-04-23 19:20:22 +00:00

We must depend on usecase, not on service

We must depend on usecase, not on service
@@ -7,2 +8,4 @@
import com.project.movienight.application.ports.input.CreateFilmLibraryCommand
import com.project.movienight.application.ports.input.CreateFilmLibraryUseCase
import com.project.movienight.application.ports.input.GetAllFilmsUseCase
import com.project.movienight.application.ports.input.GetFilmByIdUseCase
devitq (Migrated from github.com) commented 2026-04-23 19:18:44 +00:00

Same here, do not use star projections for imports

Same here, do not use star projections for imports
devitq (Migrated from github.com) commented 2026-04-23 19:19:29 +00:00

We must depend on usecases, not on service, add usecases as described in previous comments

We must depend on usecases, not on service, add usecases as described in previous comments
@@ -8,8 +8,11 @@ import com.project.movienight.application.ports.input.CreateUserUseCase
import com.project.movienight.application.ports.input.DeleteUserUseCase
devitq (Migrated from github.com) commented 2026-04-23 19:15:39 +00:00

Dont use star projections (*), use direct imports

Dont use star projections (*), use direct imports
devitq (Migrated from github.com) commented 2026-04-23 19:17:48 +00:00

Same here, no usecases have been added for those new methods

Same here, no usecases have been added for those new methods
devitq (Migrated from github.com) commented 2026-04-23 19:17:21 +00:00

No use case have been added for those two methods, thus no interface
Add usecases

No use case have been added for those two methods, thus no interface Add usecases
devitq commented 2026-05-03 12:09:19 +00:00 (Migrated from github.com)

@coderabbitai summarize

@coderabbitai summarize
coderabbitai[bot] commented 2026-05-03 12:09:25 +00:00 (Migrated from github.com)

The author of this PR is on the CodeRabbit Free Plan. In order to use the Chat feature, please upgrade the PR author to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

<!-- This is an auto-generated reply by CodeRabbit --> The author of this PR is on the CodeRabbit Free Plan. In order to use the Chat feature, please upgrade the PR author to CodeRabbit Pro by visiting <https://app.coderabbit.ai/login>.
Sign in to join this conversation.