fix: add OAuth2 support for user repository #27

Closed
skettiks wants to merge 0 commits from feat/oauth2-user-service into develop
skettiks commented 2026-04-23 16:11:13 +00:00 (Migrated from github.com)

Изначальная проблема была в том, что 26 таска делалась без учета другой таски про oauth2 (20), поэтому пришлось исправлять.

Исправлена V1 миграция - добавлена запятая после email
Реализован saveWithOAuth2() в UserRepository
Реализован findByProviderAndProviderId() в UserRepository
Обновлен CustomOAuth2UserService для использования OAuth2 методов
Исправил package declaration во всех 7 OAuth2 файлах

Summary by CodeRabbit

New Features

  • Added OAuth2 authentication with support for Google, Yandex, and VK providers
  • Enabled Spring Security framework for enhanced application security
  • Implemented password field for user account management
Изначальная проблема была в том, что 26 таска делалась без учета другой таски про oauth2 (20), поэтому пришлось исправлять. Исправлена V1 миграция - добавлена запятая после email Реализован saveWithOAuth2() в UserRepository Реализован findByProviderAndProviderId() в UserRepository Обновлен CustomOAuth2UserService для использования OAuth2 методов Исправил package declaration во всех 7 OAuth2 файлах <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## New Features * Added OAuth2 authentication with support for Google, Yandex, and VK providers * Enabled Spring Security framework for enhanced application security * Implemented password field for user account management <!-- end of auto-generated comment: release notes by coderabbit.ai -->
coderabbitai[bot] commented 2026-04-23 16:11:21 +00:00 (Migrated from github.com)

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Free

Run ID: ebf1c815-5c42-4001-8451-b7238d3ee98e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Review completed - (🔄 Check again to review again)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: skip review by coderabbit.ai --> > [!IMPORTANT] > ## Review skipped > > Auto reviews are disabled on base/target branches other than the default branch. > > > > Please check the settings in the CodeRabbit UI or the `.coderabbit.yaml` file in this repository. To trigger a single review, invoke the `@coderabbitai review` command. > > <details> > <summary>⚙️ Run configuration</summary> > > **Configuration used**: Organization UI > > **Review profile**: ASSERTIVE > > **Plan**: Free > > **Run ID**: `ebf1c815-5c42-4001-8451-b7238d3ee98e` > > </details> > > You can disable this status message by setting the `reviews.review_status` to `false` in the CodeRabbit configuration file. > > Use the checkbox below for a quick retry: > - [ ] <!-- {"checkboxId": "e9bb8d72-00e8-4f67-9cb2-caf3b22574fe"} --> ✅ Review completed - (🔄 Check again to review again) <!-- end of auto-generated comment: skip review by coderabbit.ai --> <!-- tips_start --> --- > [!NOTE] > <details> > <summary>🎁 Summarized by CodeRabbit Free</summary> > > Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting <https://app.coderabbit.ai/login>. > > </details> <sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub> <!-- tips_end -->
skettiks commented 2026-04-23 16:14:37 +00:00 (Migrated from github.com)

@coderabbitai help

@coderabbitai help
skettiks commented 2026-04-23 16:17:01 +00:00 (Migrated from github.com)

@coderabbitai review

@coderabbitai review
coderabbitai[bot] commented 2026-04-23 16:17:06 +00:00 (Migrated from github.com)
Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

<!-- This is an auto-generated reply by CodeRabbit --> <details> <summary>✅ Actions performed</summary> Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused. </details>
devitq (Migrated from github.com) requested changes 2026-04-23 19:35:14 +00:00
devitq (Migrated from github.com) left a comment

There is no like critical mistakes, but worth fixing all issues

There is no like critical mistakes, but worth fixing all issues
@@ -56,7 +58,6 @@ dependencies {
testImplementation(libs.spring.boot.starter.test)
testImplementation(libs.kotlin.test.junit5)
devitq (Migrated from github.com) commented 2026-04-23 19:25:27 +00:00

this line is redundant

this line is redundant
devitq (Migrated from github.com) commented 2026-04-23 19:31:50 +00:00

Remove gpt-like comments

Remove gpt-like comments
devitq (Migrated from github.com) commented 2026-04-23 19:30:01 +00:00

This is port, not an adapter

This is port, not an adapter
@@ -0,0 +5,4 @@
import org.springframework.security.core.authority.SimpleGrantedAuthority
import org.springframework.security.core.userdetails.UserDetails
import org.springframework.security.oauth2.core.user.OAuth2User
import java.util.*
devitq (Migrated from github.com) commented 2026-04-23 19:28:20 +00:00

Star imports is bad

Star imports is bad
@@ -0,0 +1,26 @@
package com.project.movienight.adapters.security
@Suppress("UNCHECKED_CAST")
devitq (Migrated from github.com) commented 2026-04-23 19:27:49 +00:00

Same here, remove suppress

Same here, remove suppress
@@ -0,0 +1,20 @@
package com.project.movienight.adapters.security
@Suppress("UNCHECKED_CAST")
devitq (Migrated from github.com) commented 2026-04-23 19:27:36 +00:00

Remove suppress by fixing unchecked cast

Remove suppress by fixing unchecked cast
@@ -3,2 +3,3 @@
name VARCHAR(255) NOT NULL,
email VARCHAR(320) NOT NULL UNIQUE
email VARCHAR(320) NOT NULL UNIQUE,
password VARCHAR(255)
devitq (Migrated from github.com) commented 2026-04-23 19:26:01 +00:00

Editing old migrations is a bad practice, just create a new one

Editing old migrations is a bad practice, just create a new one

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.