Fix Observability Issues and Startup Probe Failure #70

Closed
devitq wants to merge 2 commits from fix-observability-issues-17959231904052988380 into feat/setup-observability-in-k8s
devitq commented 2026-05-23 00:05:20 +00:00 (Migrated from github.com)

This PR addresses the startup probe failure and enhances the overall observability setup.

Key changes:

  1. Management Port Binding: Spring Boot was not explicitly told to bind the actuator to 8081, causing the 'connection refused' error. This is now set in application.yaml.
  2. Pod-Based Scraping: Switched vmagent from service-level scraping to pod discovery. This is more accurate for metrics and allows for better scaling. RBAC was added to permit pod listing.
  3. VM Operator Integration: Since a VictoriaMetrics Operator is present in the environment, I've added support for its CRDs (VMPodScrape, VMSingle, VMAgent) while keeping the manual setup as a fallback.
  4. JSON Logging: Added a Logback appender for JSON format to the console, triggered by a json-logging profile, which is standard for log aggregation in K8s.
  5. Startup Timing: Adjusted the startupProbe to match the requested 1-minute window.

PR created automatically by Jules for task 17959231904052988380 started by @devitq

This PR addresses the startup probe failure and enhances the overall observability setup. Key changes: 1. **Management Port Binding:** Spring Boot was not explicitly told to bind the actuator to 8081, causing the 'connection refused' error. This is now set in `application.yaml`. 2. **Pod-Based Scraping:** Switched `vmagent` from service-level scraping to pod discovery. This is more accurate for metrics and allows for better scaling. RBAC was added to permit pod listing. 3. **VM Operator Integration:** Since a VictoriaMetrics Operator is present in the environment, I've added support for its CRDs (`VMPodScrape`, `VMSingle`, `VMAgent`) while keeping the manual setup as a fallback. 4. **JSON Logging:** Added a Logback appender for JSON format to the console, triggered by a `json-logging` profile, which is standard for log aggregation in K8s. 5. **Startup Timing:** Adjusted the `startupProbe` to match the requested 1-minute window. --- *PR created automatically by Jules for task [17959231904052988380](https://jules.google.com/task/17959231904052988380) started by @devitq*
google-labs-jules[bot] commented 2026-05-23 00:05:21 +00:00 (Migrated from github.com)

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to **Reactive Mode**. When this mode is on, I will only act on comments where you specifically mention me with `@jules`. You can find this option in the **Pull Request** section of your [global Jules UI settings](https://jules.google.com/settings). You can always switch back! New to Jules? Learn more at [jules.google/docs](https://jules.google/docs). --- *_For security, I will only act on instructions from the user who triggered this task._*
coderabbitai[bot] commented 2026-05-23 00:05:28 +00:00 (Migrated from github.com)

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

βš™οΈ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 91ac3ada-d0de-47b3-b758-91b109c397f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • πŸ” Trigger review
✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-observability-issues-17959231904052988380

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: skip review by coderabbit.ai --> > [!IMPORTANT] > ## Review skipped > > Auto reviews are disabled on base/target branches other than the default branch. > > > > Please check the settings in the CodeRabbit UI or the `.coderabbit.yaml` file in this repository. To trigger a single review, invoke the `@coderabbitai review` command. > > <details> > <summary>βš™οΈ Run configuration</summary> > > **Configuration used**: Organization UI > > **Review profile**: ASSERTIVE > > **Plan**: Pro > > **Run ID**: `91ac3ada-d0de-47b3-b758-91b109c397f6` > > </details> > > You can disable this status message by setting the `reviews.review_status` to `false` in the CodeRabbit configuration file. > > Use the checkbox below for a quick retry: > - [ ] <!-- {"checkboxId": "e9bb8d72-00e8-4f67-9cb2-caf3b22574fe"} --> πŸ” Trigger review <!-- end of auto-generated comment: skip review by coderabbit.ai --> <!-- finishing_touch_checkbox_start --> <details> <summary>✨ Finishing Touches</summary> <details> <summary>πŸ§ͺ Generate unit tests (beta)</summary> - [ ] <!-- {"checkboxId": "f47ac10b-58cc-4372-a567-0e02b2c3d479", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} --> Create PR with unit tests - [ ] <!-- {"checkboxId": "6ba7b810-9dad-11d1-80b4-00c04fd430c8", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} --> Commit unit tests in branch `fix-observability-issues-17959231904052988380` </details> </details> <!-- finishing_touch_checkbox_end --> <!-- tips_start --> --- Thanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=devitq/movienight-backend&utm_content=70)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. <details> <summary>❀️ Share</summary> - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) </details> <sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub> <!-- tips_end -->
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2026-05-23 00:07:53 +00:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.