Instead of an external GitHub action, use the same markdownlint make
target from Shipyard that we use in other repos.
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
To determine the changed files, the Markdown linter needs to know the
base branch; instead of using the default everywhere, use the base
branch set in the PR.
Signed-off-by: Stephen Kitt <skitt@redhat.com>
The submainer-engine now access the node object as part
of golbalnet-healthcheck support and the required roles are
added
Signed-off-by: Aswin Surayanarayanan <asuryana@redhat.com>
Use new GHA for reporting issues when broken links are detected. This
logic was verified to work by the frequently-run flaky test finder.
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
With v3, we no longer need to initialise Helm or even provide a local
repository; the charts can be installed directly. We now support make
deploy and make e2e too, document that.
Signed-off-by: Stephen Kitt <skitt@redhat.com>
In the new event framework we use node listeners to support certain use-cases.
Currently in helm, routeagent does not have that role, so e2e tests are failing.
This PR enables it.
Related to: https://github.com/submariner-io/submariner/issues/858
Signed-Off-by: Sridhar Gaddam <sgaddam@redhat.com>
Currently, we lose updated charts when we check the gh-pages branch
out. This patch generates the charts in the base directory, and moves
them into place after checking the target branch out.
Signed-off-by: Stephen Kitt <skitt@redhat.com>
In an OCP Cluster, openshift-dns namespace has dns-default
service and this is controlled by its operator.
When Globalnet is deployed on OCP, it was seen that globalip
annotation added to it is periodically getting deleted by the
operator, so Globalnet tries to re-add the annotation and this
goes on forever. This will cause Globalnet to consume CPU
unnecessarily and could affect user-experience with Submariner
Globalnet. We have plans to enhance Globalnet to improve its
scalability, but until then we can exclude annotating services
in openshift-dns namespace.
Signed-Off-by: Sridhar Gaddam <sgaddam@redhat.com>
In an OCP Cluster, openshift-monitoring namespace has couple of
services and these are controlled by their respective operators.
When Globalnet is deployed on OCP, it was seen that globalip
annotation added to such services are periodically getting
deleted by the operators, so Globalnet tries to re-add the
annotation and this goes on forever. This will cause Globalnet
to consume CPU unnecessarily and could affect user-experience
with Submariner Globalnet. We have plans to enhance Globalnet
to improve its scalability, but until then we can exclude
annotating services in openshift-monitoring namespace.
Signed-Off-by: Sridhar Gaddam <sgaddam@redhat.com>
chart-releaser looks at the project history to determine whether a
chart changed, we mustn't limit the fetch depth.
Signed-off-by: Stephen Kitt <skitt@redhat.com>
All tests and release work has been transferred to run on GitHub
Actions, like the rest of Subariner's repos.
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Use the official Helm chart releasing GitHub Action instead of our
custom bash.
Travis CI can be removed after this commit, as all tests will have
equivalents for GHAs.
Closes: #71
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
It seems most CNCF projects provide a CODE-OF-CONDUCT.md file at the
root of their repositories, even if they have their Code of Conduct on
their website. To better fit into the CNCF ecosystem and be a more
welcoming project, follow that pattern.
Relates-to: submariner-io/submariner#804
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
It seems most CNCF projects provide a CONTRIBUTING.md file at the root
of their repositories, even if they have their contributing docs on
their website. To better fit into the CNCF ecosystem and be a more
welcoming project, follow that pattern.
Relates-to: submariner-io/submariner#804
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
The submariner-operator Helm chart deploys Submariner using the
Submariner operator: it deploys the CRDs, roles, and SAs required to
run the operator and Submariner, then pushes a Submariner CR to
instruct the operator to deploy Submariner.
This patch also adds a Makefile to validate the deployments; run
make deploy
to test the Helm charts (this will bring up two clusters, install the
broker on one of them and the operator on both, and end with a
connectivity test).
Fixes: #17
Signed-off-by: Stephen Kitt <skitt@redhat.com>
This installs the `multicluster.x-k8s.io` CRDs and roles for them
Fixes:submariner-io/lighthouse#336
Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
YAML linting currently runs on Travis. Convert to a GHA, to align with
other repos and prepare for future optimizations.
Only run against values.yaml and Chart.yaml files, as is currently the
case in the Travis-driven workflow.
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Convert MD-lint Workflow into general periodic Workflow.
Minor tweaks from refactoring in other repos.
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Combine linting GitHub Actions into a single Workflow.
Minor updates to reflect refactoring in other repos.
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Adds support for check-modified-files-only config, which currently isn't
honored and throws a warning.
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Currently, the updateStrategy for Route-agent pods is set to RollingUpdate
with maxUnavailable as 1. Because of this, when the route-agent DaemonSet
is updated, the Pods are updated one after the other. While the rolling
update strategy is good for user-facing services, for route-agent DaemonSet
its not the most suitable one as it takes time for all the route-agent pods
to be updated in a large cluster.
Ideally, it would have been great if "Recreate" updateStrategy was supported
for DaemonSets, but unfortunately K8s does not support it. But an alternate
way to achieve something similar is to configure rollingUpdate.maxUnavailable
to 100% so that the DaemonSet controller can update all the route-agent Pods
in a single go.
https://kubernetes.io/docs/tasks/manage-daemon/update-daemon-set/#daemonset-update-strategy
Fixes issue: https://github.com/submariner-io/submariner/issues/734
Signed-Off-by: Sridhar Gaddam <sgaddam@redhat.com>
* Add clusterrole to give lighthouse serviceaccount access to endpoints and
endpointslices
* Add role to give broker serviceaccont access to endpoint slices
Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
