Add Sridhar Gaddam as code owner

... since he is now a project administrator, as voted on the mailing list. Signed-off-by: Stephen Kitt <skitt@redhat.com>
Update create-issue-from-file GHA 2.3.2 to 3.0.0
2026-09-20 22:40:34 +00:00 · 2021-10-01 12:32:51 -04:00 · 2021-09-14 08:00:47 -04:00 · 2021-09-10 08:32:45 -04:00 · 2021-09-09 17:26:16 -04:00 · 2021-08-24 08:18:22 -04:00
12 changed files with 81 additions and 50 deletions
@@ -23,11 +23,9 @@ Submariner Owners: https://github.com/orgs/submariner-io/teams/submariner-core
 **Anything else we need to know?**:

 **Environment**:
- Submariner version (use `subctl version`):
- Kubernetes version (use `kubectl version`):
+- Diagnose information (use `subctl diagnose all`):
+- Gather information (use `subctl gather`):
 - Cloud provider or hardware configuration:
- OS (e.g: `cat /etc/os-release`):
- Kernel (e.g. `uname -a`):
 - Install tools:
 - Network plugin and version (if this is a network-related bug):
 - Others:
@@ -2,7 +2,7 @@
 # Configuration for probot-stale - https://github.com/probot/stale

 # Number of days of inactivity before an Issue becomes stale (pull request is overridden later)
-daysUntilStale: 60
+daysUntilStale: 120

 # Number of days of inactivity before an Issue or Pull Request with the stale label is closed.
 # Set to false to disable. If disabled, issues still need to be closed manually, but will remain marked as stale.
@@ -0,0 +1,39 @@
+---
+name: PR Dependencies
+
+on:
+  issues:
+    types:
+      - opened
+      - edited
+      - closed
+      - reopened
+      - synchronize
+  pull_request_target:
+    types:
+      - opened
+      - edited
+      - closed
+      - reopened
+      - synchronize
+  schedule:
+    - cron: '0 0/6 * * *' # every 6 hours
+
+jobs:
+  check:
+    name: Check Dependencies
+    if: github.repository_owner == 'submariner-io'
+    runs-on: ubuntu-latest
+    steps:
+      - uses: z0al/dependent-issues@70a1b2d4ee1cdc743af33498bd0204123953a887
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          # The label to use to mark dependent issues
+          label: dependent
+
+          # Enable checking for dependencies in issues.
+          check_issues: on
+
+          # A comma-separated list of keywords to mark dependency.
+          keywords: depends on, Depends on
@@ -24,7 +24,7 @@ jobs:
          - k8s_version: '1.20'
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f

      - name: Run E2E deployment and tests
        uses: submariner-io/shipyard/gh-actions/e2e@devel
@@ -11,7 +11,7 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f

      - name: Run E2E deployment and tests
        uses: submariner-io/shipyard/gh-actions/e2e@devel
@@ -19,7 +19,7 @@ jobs:
        lighthouse: ['', 'lighthouse']
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f

      - name: Run E2E deployment and tests
        uses: submariner-io/shipyard/gh-actions/e2e@devel
@@ -11,12 +11,12 @@ jobs:
    steps:
      - name: Get PR commits
        id: 'get-pr-commits'
-        uses: tim-actions/get-pr-commits@v1.1.0
+        uses: tim-actions/get-pr-commits@55b867b9b28954e6f5c1a0fe2f729dc926c306d0
        with:
          token: ${{ secrets.GITHUB_TOKEN }}

      - name: 'Verify no "Apply suggestions from code review" commits'
-        uses: tim-actions/commit-message-checker-with-regex@v0.3.1
+        uses: tim-actions/commit-message-checker-with-regex@d6d9770051dd6460679d1cab1dcaa8cffc5c2bbd
        with:
          commits: ${{ steps.get-pr-commits.outputs.commits }}
          pattern: '^(?!.*(apply suggestions from code review))'
@@ -28,20 +28,20 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f

      - name: Set up Helm
-        uses: azure/setup-helm@v1
+        uses: azure/setup-helm@18bc76811624f360dbd7f18c2d4ecb32c7b87bab
        with:
          version: v3.6.0

      - name: Set up Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@dc73133d4da04e56a135ae2246682783cc7c7cb6
        with:
          python-version: '3.x'

      - name: Set up helm/chart-testing
-        uses: helm/chart-testing-action@v2.1.0
+        uses: helm/chart-testing-action@5f16c27cf7a4fa9c776ff73734df3909b2b65127

      - name: Run helm/chart-testing (lint)
        run: ct lint --config ct.yaml
@@ -51,7 +51,7 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
        with:
          fetch-depth: 0
      - name: Run gitlint
@@ -62,33 +62,20 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f

      - name: Run helm-docs and verify docs are up-to-date
-        run: |
-          HELM_DOCS_VERSION="0.15.0"
-          # Avoid polluting repo with helm-docs' README/LICENSE or other files in the release archive
-          cd /tmp
-          curl -sL "https://github.com/norwoodj/helm-docs/releases/download/v${HELM_DOCS_VERSION}/helm-docs_${HELM_DOCS_VERSION}_Linux_x86_64.tar.gz" | tar zx
-          cd -
-          /tmp/helm-docs
-          if [[ ! -z "$(git status --porcelain)" ]]; then
-            echo "Helm docs not up-to-date:"
-            git status --porcelain
-            git diff
-            echo "Run helm-docs, as the CI does above, and commit the updated docs."
-            exit 1
-          fi
+        run: make helm-docs

  markdown-link-check:
    name: Markdown Links (modified files)
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f

      - name: Run markdown-link-check
-        uses: gaurav-nelson/github-action-markdown-link-check@v1
+        uses: gaurav-nelson/github-action-markdown-link-check@9710f0fec812ce0a3b98bef4c9d842fc1f39d976
        with:
          config-file: ".markdownlinkcheck.json"
          check-modified-files-only: "yes"
@@ -99,7 +86,7 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
      - name: Run markdownlint
        run: make markdownlint

@@ -108,9 +95,10 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
      - name: Run yamllint
-        uses: ibiqlik/action-yamllint@v1
+        uses: ibiqlik/action-yamllint@ed2b6e911569708ed121c14b87d513860a7e36a7
        with:
          file_or_dir: submariner-k8s-broker/Chart.yaml submariner-k8s-broker/values.yaml submariner-operator/Chart.yaml submariner-operator/values.yaml
          config_file: .yamllint.yml
+          strict: true
@@ -12,16 +12,16 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f

      - name: Run markdown-link-check
-        uses: gaurav-nelson/github-action-markdown-link-check@v1
+        uses: gaurav-nelson/github-action-markdown-link-check@9710f0fec812ce0a3b98bef4c9d842fc1f39d976
        with:
          config-file: ".markdownlinkcheck.json"

      - name: Raise an Issue to report broken links
        if: ${{ failure() }}
-        uses: peter-evans/create-issue-from-file@v2.3.2
+        uses: peter-evans/create-issue-from-file@97e6f902a416aac38834e23fa52e166aad0437d2
        with:
          title: Broken link detected by CI
          content-filepath: .github/ISSUE_TEMPLATE/broken-link.md
@@ -13,7 +13,7 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
        with:
          fetch-depth: 0

@@ -1,9 +0,0 @@
-[general]
-# body-is-missing: Allow commit messages with only a title
-# body-min-length: Allow short body lines, like "Relates-to: #issue"
-ignore=body-is-missing,body-min-length
-
-[ignore-by-body]
-# Dependabot doesn't follow our conventions, unfortunately
-regex=^Signed-off-by: dependabot\[bot\](.*)
-ignore=all
@@ -1 +1 @@
-* @mangelajo @Oats87 @skitt @tpantelis
+* @mangelajo @Oats87 @skitt @sridhargaddam @tpantelis
@@ -22,6 +22,7 @@ export DEPLOY_ARGS
 GH_URL=https://submariner-io.github.io/submariner-charts/charts
 CHARTS_DIR=charts
 CHARTS_VERSION=0.7.0
+HELM_DOCS_VERSION=0.15.0
 REPO_URL=$(shell git config remote.origin.url)

 # Process extra flags from the `using=a,b,c` optional flag
@@ -42,6 +43,20 @@ e2e: E2E_ARGS=cluster1 cluster2
 	helm dep update $(subst -$(CHARTS_VERSION),,$(basename $(@F)))
 	helm package --version $(CHARTS_VERSION) $(subst -$(CHARTS_VERSION),,$(basename $(@F)))

+helm-docs:
+	# Avoid polluting repo with helm-docs' README/LICENSE or other files in the release archive
+	cd /tmp && \
+	curl -sL https://github.com/norwoodj/helm-docs/releases/download/v$(HELM_DOCS_VERSION)/helm-docs_$(HELM_DOCS_VERSION)_Linux_x86_64.tar.gz | tar zx && \
+	cd -
+	/tmp/helm-docs
+	if [ ! -z $(git status --porcelain) ]; then \
+		echo "Helm docs not up-to-date:"; \
+		git status --porcelain; \
+		git diff; \
+		echo "Run make helm-docs locally to generate updated docs, commit the updates."; \
+		exit 1; \
+	fi
+
 release: submariner-k8s-broker-$(CHARTS_VERSION).tgz submariner-operator-$(CHARTS_VERSION).tgz
 	git checkout gh-pages
 	mv *.tgz $(CHARTS_DIR)
@@ -51,7 +66,7 @@ release: submariner-k8s-broker-$(CHARTS_VERSION).tgz submariner-operator-$(CHART
 	  helm repo index $(CHARTS_DIR) --url $(GH_URL); \
 	fi

-.PHONY: release
+.PHONY: release helm-docs

 else
Author	SHA1	Message	Date
Stephen KittandThomas Pantelis	ea1df8ed54	Add Sridhar Gaddam as code owner ... since he is now a project administrator, as voted on the mailing list. Signed-off-by: Stephen Kitt <skitt@redhat.com>	2021-10-01 12:32:51 -04:00
Daniel FarrellandThomas Pantelis	2788692ffc	Update create-issue-from-file GHA 2.3.2 to 3.0.0 Signed-off-by: Daniel Farrell <dfarrell@redhat.com>	2021-09-14 08:00:47 -04:00
Daniel FarrellandThomas Pantelis	87390b6e5d	Enable strict YAML linting Fail yamllint on warnings, as we do with other repos. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>	2021-09-10 08:32:45 -04:00
Daniel FarrellandThomas Pantelis	47a7aec05d	Update ibiqlik/action-yamllint GHA 1.0.0 to 3.0.4 Signed-off-by: Daniel Farrell <dfarrell@redhat.com>	2021-09-09 17:26:16 -04:00
Daniel FarrellandThomas Pantelis	eea398da4e	Use SHAs for GHA versions Per GitHub's security guidelines, GHAs should be pinned using full length commit SHAs instead of tags. The SHAs are of the commits currently resolved by the versions. Even "trusted" GHAs from GitHub developers are pinned because it's possible their repo rights could be compromised and a malicious GHA published. These core repos are not frequently substantially updated. Submariner-internal GHAs are left pinned at devel because we want automatic updates from Shipyard's shared tooling. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>	2021-08-24 08:18:22 -04:00
Daniel FarrellandDaniel Farrell	50489802e2	Don't run periodic PR dependency checks on forks As we do with the Flake Finder and other periodic jobs, skip the checks for PR dependencies on forks. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>	2021-08-09 16:39:00 -04:00
Janki ChhatbarandGitHub	cb78ab7aaa	Remove duplicated information (#162 ) Submariner, k8s, OS and kernel information are collected as part of `subctl gather`. Don't ask for them explicitly in bug report. Signed-off-by: Janki Chhatbar <jchhatba@redhat.com>	2021-07-27 09:47:20 +00:00
Daniel FarrellandDaniel Farrell	2f9156cf34	Extract helm-docs generation/testing to Makefile Signed-off-by: Daniel Farrell <dfarrell@redhat.com>	2021-07-27 05:00:56 -04:00
Stephen KittandThomas Pantelis	4b48a3d30c	Remove project-specific gitlint configuration We now use Shipyard's gitlint configuration everywhere. Signed-off-by: Stephen Kitt <skitt@redhat.com>	2021-07-22 22:23:50 -04:00
Janki ChhatbarandDaniel Farrell	78294c1827	Enable PR dependency check jobs This job marks a PR `dependent` whenever a dependent PR is mentioned via `Depends on/ depends on` keyword. The job fails until the dependent PR is not merged. This helps in properly managing merging of dependent PRs. Signed-off-by: Janki Chhatbar <jchhatba@redhat.com>	2021-07-22 10:18:28 -04:00
Stephen KittandThomas Pantelis	29c87078b5	Increase days until stale to 120 This gives us a little over a full release to work on issues. Signed-off-by: Stephen Kitt <skitt@redhat.com>	2021-07-16 15:04:52 -04:00