Fix connectionHealthCheck

connectionHealthCheck in submariner CR is a nested field but is being added as a variable. This means it is ignored and the field isn't set correctly in gateway pods. Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
Add RBAC permission endpointslices/restricted in broker roles
2026-09-20 21:30:35 +00:00 · 2021-10-27 12:36:06 -04:00 · 2021-10-26 08:12:41 -04:00 · 2021-10-25 09:12:47 -04:00 · 2021-10-25 09:12:47 -04:00 · 2021-10-25 09:12:47 -04:00
17 changed files with 62 additions and 37 deletions
@@ -5,8 +5,8 @@ on:
  pull_request:

 jobs:
-  target_devel:
-    name: PR targets devel
+  target_branch:
+    name: PR targets branch
    runs-on: ubuntu-latest
    steps:
      - name: Check that the PR targets devel
@@ -22,6 +22,7 @@ on:
 jobs:
  check:
    name: Check Dependencies
+    if: github.repository_owner == 'submariner-io'
    runs-on: ubuntu-latest
    steps:
      - uses: z0al/dependent-issues@70a1b2d4ee1cdc743af33498bd0204123953a887
@@ -35,4 +36,4 @@ jobs:
          check_issues: on

          # A comma-separated list of keywords to mark dependency.
-          keywords: depends on, Depends on
+          keywords: depends on, Depends on
@@ -24,7 +24,7 @@ jobs:
          - k8s_version: '1.20'
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f

      - name: Run E2E deployment and tests
        uses: submariner-io/shipyard/gh-actions/e2e@devel
@@ -11,7 +11,7 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f

      - name: Run E2E deployment and tests
        uses: submariner-io/shipyard/gh-actions/e2e@devel
@@ -19,7 +19,7 @@ jobs:
        lighthouse: ['', 'lighthouse']
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f

      - name: Run E2E deployment and tests
        uses: submariner-io/shipyard/gh-actions/e2e@devel
@@ -11,12 +11,12 @@ jobs:
    steps:
      - name: Get PR commits
        id: 'get-pr-commits'
-        uses: tim-actions/get-pr-commits@v1.1.0
+        uses: tim-actions/get-pr-commits@55b867b9b28954e6f5c1a0fe2f729dc926c306d0
        with:
          token: ${{ secrets.GITHUB_TOKEN }}

      - name: 'Verify no "Apply suggestions from code review" commits'
-        uses: tim-actions/commit-message-checker-with-regex@v0.3.1
+        uses: tim-actions/commit-message-checker-with-regex@d6d9770051dd6460679d1cab1dcaa8cffc5c2bbd
        with:
          commits: ${{ steps.get-pr-commits.outputs.commits }}
          pattern: '^(?!.*(apply suggestions from code review))'
@@ -28,20 +28,20 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f

      - name: Set up Helm
-        uses: azure/setup-helm@v1
+        uses: azure/setup-helm@18bc76811624f360dbd7f18c2d4ecb32c7b87bab
        with:
          version: v3.6.0

      - name: Set up Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@dc73133d4da04e56a135ae2246682783cc7c7cb6
        with:
          python-version: '3.x'

      - name: Set up helm/chart-testing
-        uses: helm/chart-testing-action@v2.1.0
+        uses: helm/chart-testing-action@5f16c27cf7a4fa9c776ff73734df3909b2b65127

      - name: Run helm/chart-testing (lint)
        run: ct lint --config ct.yaml
@@ -51,7 +51,7 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
        with:
          fetch-depth: 0
      - name: Run gitlint
@@ -62,7 +62,7 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f

      - name: Run helm-docs and verify docs are up-to-date
        run: make helm-docs
@@ -72,10 +72,10 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f

      - name: Run markdown-link-check
-        uses: gaurav-nelson/github-action-markdown-link-check@v1
+        uses: gaurav-nelson/github-action-markdown-link-check@9710f0fec812ce0a3b98bef4c9d842fc1f39d976
        with:
          config-file: ".markdownlinkcheck.json"
          check-modified-files-only: "yes"
@@ -86,7 +86,7 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
      - name: Run markdownlint
        run: make markdownlint

@@ -95,9 +95,10 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
      - name: Run yamllint
-        uses: ibiqlik/action-yamllint@v1
+        uses: ibiqlik/action-yamllint@ed2b6e911569708ed121c14b87d513860a7e36a7
        with:
          file_or_dir: submariner-k8s-broker/Chart.yaml submariner-k8s-broker/values.yaml submariner-operator/Chart.yaml submariner-operator/values.yaml
          config_file: .yamllint.yml
+          strict: true
@@ -12,16 +12,16 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f

      - name: Run markdown-link-check
-        uses: gaurav-nelson/github-action-markdown-link-check@v1
+        uses: gaurav-nelson/github-action-markdown-link-check@9710f0fec812ce0a3b98bef4c9d842fc1f39d976
        with:
          config-file: ".markdownlinkcheck.json"

      - name: Raise an Issue to report broken links
        if: ${{ failure() }}
-        uses: peter-evans/create-issue-from-file@v2.3.2
+        uses: peter-evans/create-issue-from-file@97e6f902a416aac38834e23fa52e166aad0437d2
        with:
          title: Broken link detected by CI
          content-filepath: .github/ISSUE_TEMPLATE/broken-link.md
@@ -13,7 +13,7 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
        with:
          fetch-depth: 0

@@ -1 +1 @@
-* @mangelajo @Oats87 @skitt @tpantelis
+* @mangelajo @Oats87 @skitt @sridhargaddam @tpantelis
@@ -21,7 +21,7 @@ override DEPLOY_ARGS += $(CLUSTER_SETTINGS_FLAG) --deploytool helm
 export DEPLOY_ARGS
 GH_URL=https://submariner-io.github.io/submariner-charts/charts
 CHARTS_DIR=charts
-CHARTS_VERSION=0.7.0
+CHARTS_VERSION=0.10.1
 HELM_DOCS_VERSION=0.15.0
 REPO_URL=$(shell git config remote.origin.url)

@@ -16,7 +16,7 @@ rules:
  resources: ["*"]
  verbs: ["create", "get", "list", "watch", "patch", "update", "delete"]
 - apiGroups: ["discovery.k8s.io"]
-  resources: ["endpointslices"]
+  resources: ["endpointslices", "endpointslices/restricted"]
  verbs: ["create", "get", "list", "watch","patch", "update", "delete"]
 - apiGroups: ["multicluster.x-k8s.io"]
  resources: ["*"]
@@ -1,8 +1,8 @@
 ---
 name: submariner-operator
-version: 0.7.0
+version: 0.10.1
 apiVersion: v2
-appVersion: 0.7.0
+appVersion: 0.10.1
 description: Submariner enables direct networking between Pods and Services in different Kubernetes clusters
 keywords:
 home: https://submariner-io.github.io/
@@ -1,6 +1,6 @@
 # submariner-operator

-![Version: 0.7.0](https://img.shields.io/badge/Version-0.7.0-informational?style=flat-square) ![AppVersion: 0.7.0](https://img.shields.io/badge/AppVersion-0.7.0-informational?style=flat-square)
+![Version: 0.10.1](https://img.shields.io/badge/Version-0.10.1-informational?style=flat-square) ![AppVersion: 0.10.1](https://img.shields.io/badge/AppVersion-0.10.1-informational?style=flat-square)

 Submariner enables direct networking between Pods and Services in different Kubernetes clusters

@@ -27,8 +27,9 @@ Submariner enables direct networking between Pods and Services in different Kube
 | broker.server | string | `"example.k8s.apiserver"` |  |
 | broker.token | string | `"test"` |  |
 | gateway.image.repository | string | `"quay.io/submariner/submariner-gateway"` |  |
-| gateway.image.tag | string | `"0.7.0"` |  |
+| gateway.image.tag | string | `"0.10.1"` |  |
 | ipsec.debug | bool | `false` |  |
+| ipsec.forceUDPEncaps | bool | `false` |  |
 | ipsec.ikePort | int | `500` |  |
 | ipsec.natPort | int | `4500` |  |
 | ipsec.psk | string | `""` |  |
@@ -38,7 +39,7 @@ Submariner enables direct networking between Pods and Services in different Kube
 | operator.affinity | object | `{}` |  |
 | operator.image.pullPolicy | string | `"IfNotPresent"` |  |
 | operator.image.repository | string | `"quay.io/submariner/submariner-operator"` |  |
-| operator.image.tag | string | `"0.7.0"` |  |
+| operator.image.tag | string | `"0.10.1"` |  |
 | operator.resources | object | `{}` |  |
 | operator.tolerations | list | `[]` |  |
 | rbac.create | bool | `true` |  |
@@ -58,10 +59,12 @@ Submariner enables direct networking between Pods and Services in different Kube
 | submariner.clusterCidr | string | `""` |  |
 | submariner.clusterId | string | `""` |  |
 | submariner.colorCodes | string | `"blue"` |  |
+| submariner.coreDNSCustomConfig | object | `{}` |  |
 | submariner.debug | bool | `false` |  |
 | submariner.globalCidr | string | `""` |  |
+| submariner.healthcheckEnabled | bool | `true` |  |
 | submariner.images.repository | string | `"quay.io/submariner"` |  |
-| submariner.images.tag | string | `"0.7.0"` |  |
+| submariner.images.tag | string | `"0.10.1"` |  |
 | submariner.natEnabled | bool | `false` |  |
 | submariner.serviceCidr | string | `""` |  |
 | submariner.serviceDiscovery | bool | `true` |  |
@@ -13,7 +13,7 @@ questions:
    type: string
    label: Submariner Operator Image Repository
  - variable: operator.image.tag
-    default: "0.7.0"
+    default: "0.10.1"
    description: "Submariner Operator Image Tag"
    type: string
    label: Submariner Operator Image Tag
@@ -31,7 +31,7 @@ questions:
    type: string
    label: Submariner Repository
  - variable: submariner.images.tag
-    default: "0.7.0"
+    default: "0.10.1"
    description: "Submariner Images Tag (shared for all non-operator images)"
    type: string
    label: Submariner Images Tag
@@ -136,3 +136,9 @@ questions:
  group: "Advanced Configuration"
  description: "Cable driver implementation"
  label: "Cable Driver"
+- variable: submariner.healthcheckEnabled
+  type: boolean
+  default: true
+  group: "Advanced Configuration"
+  description: "Disable Healthcheck"
+  label: "Healthcheck Disabled"
@@ -734,6 +734,7 @@ rules:
      - discovery.k8s.io
    resources:
      - endpointslices
+      - endpointslices/restricted
    verbs:
      - create
      - get
@@ -10,6 +10,7 @@ spec:
  brokerK8sCA: {{ .Values.broker.ca }}
  brokerK8sRemoteNamespace: {{ .Values.broker.namespace }}
  ceIPSecDebug: {{ .Values.ipsec.debug }}
+  ceIPSecForceUDPEncaps: {{ .Values.ipsec.forceUDPEncaps }}
  ceIPSecIKEPort: {{ .Values.ipsec.ikePort }}
  ceIPSecNATTPort: {{ .Values.ipsec.natPort }}
  ceIPSecPSK: {{ .Values.ipsec.psk }}
@@ -25,3 +26,12 @@ spec:
  globalCIDR: "{{ .Values.submariner.globalCidr }}"
  serviceDiscoveryEnabled: {{ .Values.submariner.serviceDiscovery }}
  cableDriver: {{ .Values.submariner.cableDriver }}
+  connectionHealthCheck:
+    enabled: {{ .Values.submariner.healthcheckEnabled }}
+    intervalSeconds: 1
+    maxPacketLossCount: 5
+{{- with .Values.submariner.coreDNSCustomConfig }}
+  coreDNSCustomConfig:
+    configmapName: .configmapName
+    namespace: .namespace
+{{- end }}
@@ -10,9 +10,11 @@ submariner:
  debug: false
  serviceDiscovery: true
  cableDriver: "libreswan"
+  healthcheckEnabled: true
+  coreDNSCustomConfig: {}
  images:
    repository: quay.io/submariner
-    tag: "0.7.0"
+    tag: "0.10.1"
 broker:
  server: example.k8s.apiserver
  token: test
@@ -25,6 +27,7 @@ rbac:
 ipsec:
  psk: ""
  debug: false
+  forceUDPEncaps: false
  ikePort: 500
  natPort: 4500
 leadership:
@@ -34,7 +37,7 @@ leadership:
 operator:
  image:
    repository: quay.io/submariner/submariner-operator
-    tag: "0.7.0"
+    tag: "0.10.1"
    pullPolicy: IfNotPresent
  resources: {}
  tolerations: []
@@ -42,7 +45,7 @@ operator:
 gateway:
  image:
    repository: quay.io/submariner/submariner-gateway
-    tag: "0.7.0"
+    tag: "0.10.1"
 serviceAccounts:
  operator:
    create: true
Author	SHA1	Message	Date
Vishal ThaparandDaniel Farrell	220ccc34f5	Fix connectionHealthCheck connectionHealthCheck in submariner CR is a nested field but is being added as a variable. This means it is ignored and the field isn't set correctly in gateway pods. Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>	2021-10-27 12:36:06 -04:00
Aswin SurayanarayananandThomas Pantelis	c3a885fec9	Add RBAC permission endpointslices/restricted in broker roles Fixes : github.com/submariner-io/lighthouse/issues#627 Signed-off-by: Aswin Surayanarayanan <asuryana@redhat.com>	2021-10-26 08:12:41 -04:00
Víctor Felipe Godoy Hernández Thomas Pantelis Sridhar Gaddam	17f4fecfd9	Update submariner-operator/questions.yml Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: Victor Godoy Hernández <vigohe@gmail.com>	2021-10-25 09:12:47 -04:00
Victor Godoy HernándezandThomas Pantelis	9ee272bec8	Update Readme.md Signed-off-by: Victor Godoy Hernández <vigohe@gmail.com>	2021-10-25 09:12:47 -04:00
Victor Godoy HernándezandThomas Pantelis	9347e8f345	Add ceIPSecForceUDPEncaps & coreDNSCustomConfig variables Signed-off-by: Victor Godoy Hernández <vigohe@gmail.com>	2021-10-25 09:12:47 -04:00
Victor Godoy HernándezandThomas Pantelis	916f255461	Add enable/disable connectionHealthCheck Signed-off-by: Victor Godoy Hernández <vigohe@gmail.com>	2021-10-25 09:12:47 -04:00
Victor Godoy HernándezandThomas Pantelis	756daf344e	Bump up to 0.10.1 Signed-off-by: Victor Godoy Hernández <vigohe@gmail.com>	2021-10-25 09:12:47 -04:00
Mike KolesnikandThomas Pantelis	839d20f972	Rename job so it won't shard on stable branches Right now auto release logic updates `devel` to the stable branch name when creating stable branches. This leads to this job "sharding" into multiple jobs, and messes up branch protections. To keep things simple, the main job name will remain the same so that there's no "PR targets X" and "PR targets Y" jobs, just the one "PR targets branch" job Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>	2021-10-20 11:18:35 -04:00
Vishal ThaparandStephen Kitt	6b7fed425a	Add endpontslices/restricted to lighthouse-agent Fixes: submariner-io/lighthouse#627 Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>	2021-10-19 16:22:31 +02:00
Stephen KittandThomas Pantelis	ea1df8ed54	Add Sridhar Gaddam as code owner ... since he is now a project administrator, as voted on the mailing list. Signed-off-by: Stephen Kitt <skitt@redhat.com>	2021-10-01 12:32:51 -04:00
Daniel FarrellandThomas Pantelis	2788692ffc	Update create-issue-from-file GHA 2.3.2 to 3.0.0 Signed-off-by: Daniel Farrell <dfarrell@redhat.com>	2021-09-14 08:00:47 -04:00
Daniel FarrellandThomas Pantelis	87390b6e5d	Enable strict YAML linting Fail yamllint on warnings, as we do with other repos. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>	2021-09-10 08:32:45 -04:00
Daniel FarrellandThomas Pantelis	47a7aec05d	Update ibiqlik/action-yamllint GHA 1.0.0 to 3.0.4 Signed-off-by: Daniel Farrell <dfarrell@redhat.com>	2021-09-09 17:26:16 -04:00
Daniel FarrellandThomas Pantelis	eea398da4e	Use SHAs for GHA versions Per GitHub's security guidelines, GHAs should be pinned using full length commit SHAs instead of tags. The SHAs are of the commits currently resolved by the versions. Even "trusted" GHAs from GitHub developers are pinned because it's possible their repo rights could be compromised and a malicious GHA published. These core repos are not frequently substantially updated. Submariner-internal GHAs are left pinned at devel because we want automatic updates from Shipyard's shared tooling. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>	2021-08-24 08:18:22 -04:00
Daniel FarrellandDaniel Farrell	50489802e2	Don't run periodic PR dependency checks on forks As we do with the Flake Finder and other periodic jobs, skip the checks for PR dependencies on forks. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>	2021-08-09 16:39:00 -04:00