fix(rbac): add missing cluster roles to submariner-operator

Signed-off-by: Steve Mattar <smattar@redhat.com>
Add pull request template
2026-09-21 03:20:35 +00:00 · 2021-05-24 14:40:13 -05:00 · 2021-05-20 12:34:36 -04:00 · 2021-05-20 12:50:16 +02:00 · 2021-05-12 07:35:11 -04:00 · 2021-05-03 09:29:11 -04:00
13 changed files with 38 additions and 17 deletions
@@ -6,7 +6,7 @@ labels: support
 ---

 <!--
-GitHub may not the right place for support requests.
+GitHub may not be the right place for support requests.

 You can also post your question on the [Submariner
 Slack](https://kubernetes.slack.com/archives/C010RJV694M) or the Submariner
@@ -0,0 +1,13 @@
+<!--  Thanks for sending a pull request!  Here are some tips for you:
+
+1. If this is your first time, please read our developer guide: https://submariner.io/development/
+2. Ensure you have added the appropriate tests for your PR: https://submariner.io/development/code-review/#test-new-functionality
+3. Read the code review guide to ease the review process: https://submariner.io/development/code-review/
+4. If the PR is unfinished, mark it as a draft: https://submariner.io/development/code-review/#mark-work-in-progress-prs-as-drafts
+5. If you are using CI to debug, use your private fork: https://submariner.io/development/code-review/#use-private-forks-for-debugging-prs-by-running-ci
+6. Add labels to the PR as appropriate.
+
+This template is based on the K8s/K8s template:
+
+https://github.com/kubernetes/kubernetes/blob/master/.github/PULL_REQUEST_TEMPLATE.md
+-->
@@ -6,9 +6,9 @@ on:

 jobs:
  target_devel:
-    name: PR targets release-0.9
+    name: PR targets devel
    runs-on: ubuntu-latest
    steps:
-      - name: Check that the PR targets release-0.9
-        if: ${{ github.base_ref != 'release-0.9' }}
+      - name: Check that the PR targets devel
+        if: ${{ github.base_ref != 'devel' }}
        run: exit 1
@@ -26,11 +26,11 @@ jobs:
        uses: actions/checkout@v2

      - name: Run E2E deployment and tests
-        uses: submariner-io/shipyard/gh-actions/e2e@release-0.9
+        uses: submariner-io/shipyard/gh-actions/e2e@devel
        with:
          k8s_version: ${{ matrix.k8s_version }}
          using: ${{ matrix.cable_driver }} ${{ matrix.globalnet }} ${{ matrix.lighthouse }}

      - name: Post mortem
        if: failure()
-        uses: submariner-io/shipyard/gh-actions/post-mortem@release-0.9
+        uses: submariner-io/shipyard/gh-actions/post-mortem@devel
@@ -8,6 +8,7 @@ on:
 jobs:
  e2e:
    name: E2E
+    if: github.repository_owner == 'submariner-io'
    timeout-minutes: 30
    runs-on: ubuntu-latest
    strategy:
@@ -21,10 +22,10 @@ jobs:
        uses: actions/checkout@v2

      - name: Run E2E deployment and tests
-        uses: submariner-io/shipyard/gh-actions/e2e@release-0.9
+        uses: submariner-io/shipyard/gh-actions/e2e@devel
        with:
          using: ${{ matrix.cable_driver }} ${{ matrix.globalnet }} ${{ matrix.lighthouse }}

      - name: Post mortem
        if: failure()
-        uses: submariner-io/shipyard/gh-actions/post-mortem@release-0.9
+        uses: submariner-io/shipyard/gh-actions/post-mortem@devel
@@ -8,6 +8,7 @@ on:
 jobs:
  markdown-link-check-periodic:
    name: Markdown Links (all files)
+    if: github.repository_owner == 'submariner-io'
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repository
@@ -4,11 +4,12 @@ name: Release Charts
 on:
  push:
    branches:
-      - release-0.9
+      - devel

 jobs:
  release:
    name: Release
+    if: github.repository_owner == 'submariner-io'
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
@@ -1,5 +1,5 @@
 ARG BASE_BRANCH
-FROM quay.io/submariner/shipyard-dapper-base:release-0.9
+FROM quay.io/submariner/shipyard-dapper-base:${BASE_BRANCH}

 ARG DAPPER_HOST_ARCH
 ENV HOST_ARCH=${DAPPER_HOST_ARCH} ARCH=${DAPPER_HOST_ARCH} \
@@ -1,4 +1,4 @@
-BASE_BRANCH ?= release-0.9
+BASE_BRANCH ?= devel
 export BASE_BRANCH

 ifneq (,$(DAPPER_HOST_ARCH))
@@ -1,5 +1,12 @@
 # submariner-charts

+<!-- markdownlint-disable line-length -->
+[![CII Best Practices](https://bestpractices.coreinfrastructure.org/projects/4865/badge)](https://bestpractices.coreinfrastructure.org/projects/4865)
+[![Release Charts](https://github.com/submariner-io/submariner-charts/workflows/Release%20Charts/badge.svg)](https://github.com/submariner-io/submariner-charts/actions?query=workflow%3A%22Release+Charts%22)
+[![Periodic](https://github.com/submariner-io/submariner-charts/workflows/Periodic/badge.svg)](https://github.com/submariner-io/submariner-charts/actions?query=workflow%3APeriodic)
+[![Flake Finder](https://github.com/submariner-io/submariner-charts/workflows/Flake%20Finder/badge.svg)](https://github.com/submariner-io/submariner-charts/actions?query=workflow%3A%22Flake+Finder%22)
+<!-- markdownlint-enable line-length -->
+
 Please see the [Helm docs on Submariner's website](https://submariner.io/operations/deployment/helm/).

 ## Development workflow
@@ -1,7 +1,6 @@
 ---
 name: submariner-k8s-broker
 version: 0.6.0
-apiVersion: v2
 appVersion: 0.6.0
 description: Submariner Kubernetes Broker
 keywords:
@@ -2,7 +2,7 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:
-  name: {{ template "submariner-k8s-broker.fullname" . }}-cluster
+  name: {{ template "submariner-k8s-broker.fullname" . }}:client
  labels:
    heritage: {{ .Release.Service | quote }}
    release: {{ .Release.Name | quote }}
@@ -25,13 +25,13 @@ rules:
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
-  name: {{ template "submariner-k8s-broker.fullname" . }}-cluster
+  name: {{ template "submariner-k8s-broker.fullname" . }}:client
 roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: Role
-  name: {{ template "submariner-k8s-broker.fullname" . }}-cluster
+  name: {{ template "submariner-k8s-broker.fullname" . }}:client
 subjects:
 - kind: ServiceAccount
  name: {{ template "submariner-k8s-broker.clientServiceAccountName" . }}
  namespace: {{ .Release.Namespace }}
-{{- end -}}
+{{- end -}}
@@ -1,7 +1,6 @@
 ---
 name: submariner-operator
 version: 0.7.0
-apiVersion: v2
 appVersion: 0.7.0
 description: Submariner enables direct networking between Pods and Services in different Kubernetes clusters
 keywords:
Author	SHA1	Message	Date
Steve MattarandDaniel Farrell	12c8e9b3ff	fix(rbac): add missing cluster roles to submariner-operator Signed-off-by: Steve Mattar <smattar@redhat.com>	2021-05-24 14:40:13 -05:00
Daniel FarrellandThomas Pantelis	55b0610620	Add pull request template Add a template for PRs with tips and pointers to docs. This completes a recommendation of the CII Best Practices program: > It is SUGGESTED that this policy on adding tests (see test_policy) be documented in the instructions for change proposals. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>	2021-05-20 12:34:36 -04:00
Daniel FarrellandMiguel Angel Ajo Pelayo	4b52dc668e	Add CII and merged-CI badges to README Add Submariner's CII Best Practices badge to the README. Add badges for workflows run against merged code. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>	2021-05-20 12:50:16 +02:00
Mike KolesnikandThomas Pantelis	6f94f29563	Don't run certain GHA jobs on forks Don't run jobs that aren't triggered on pull request on forks. Forks aren't likely to need these jobs, and theyre more likely to fail there. Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>	2021-05-12 07:35:11 -04:00
nyechielandThomas Pantelis	f0a0ae93bf	Fix a typo in support issue template Signed-off-by: nyechiel <nyechiel@redhat.com>	2021-05-03 09:29:11 -04:00