chore(backend/api): naming improvements

src/backend/api/v1/reviews/endpoints.py

@@ -51,7 +51,7 @@ def list_approver_groups(
     request: HttpRequest,
     limit: int = 50,
     offset: int = 0,
-) -> tuple[int, ApproverGroupListOut]:
+) -> tuple[HTTPStatus, ApproverGroupListOut]:
     qs = approver_group_list()
     total = qs.count()
     items = [
@@ -75,7 +75,7 @@ def list_approver_groups(
 def create_approver_group(
     request: HttpRequest,
     payload: ApproverGroupCreateIn,
-) -> tuple[int, ApproverGroupOut]:
+) -> tuple[HTTPStatus, ApproverGroupOut]:
     experimenter = get_object_or_404(User, pk=payload.experimenter_id)
 
     group = approver_group_create(
@@ -102,7 +102,7 @@ def create_approver_group(
 def get_approver_group(
     request: HttpRequest,
     group_id: str,
-) -> tuple[int, ApproverGroupOut]:
+) -> tuple[HTTPStatus, ApproverGroupOut]:
     group = get_object_or_404(
         ApproverGroup.objects.select_related("experimenter").prefetch_related(
             "approvers"
@@ -126,7 +126,7 @@ def update_approver_group(
     request: HttpRequest,
     group_id: str,
     payload: ApproverGroupUpdateIn,
-) -> tuple[int, ApproverGroupOut]:
+) -> tuple[HTTPStatus, ApproverGroupOut]:
     group = get_object_or_404(
         ApproverGroup.objects.select_related("experimenter").prefetch_related(
             "approvers"
@@ -161,7 +161,7 @@ def update_approver_group(
 def delete_approver_group(
     request: HttpRequest,
     group_id: str,
-) -> tuple[int, None]:
+) -> tuple[HTTPStatus, None]:
     group = get_object_or_404(
         ApproverGroup.objects.select_related("experimenter").prefetch_related(
             "approvers"
@@ -186,7 +186,7 @@ def add_approver_to_group(
     request: HttpRequest,
     group_id: str,
     payload: ApproverGroupAddApproverIn,
-) -> tuple[int, ApproverGroupOut]:
+) -> tuple[HTTPStatus, ApproverGroupOut]:
     group = get_object_or_404(
         ApproverGroup.objects.select_related("experimenter").prefetch_related(
             "approvers"
@@ -220,7 +220,7 @@ def remove_approver_from_group(
     request: HttpRequest,
     group_id: str,
     payload: ApproverGroupRemoveApproverIn,
-) -> tuple[int, ApproverGroupOut]:
+) -> tuple[HTTPStatus, ApproverGroupOut]:
     group = get_object_or_404(
         ApproverGroup.objects.select_related("experimenter").prefetch_related(
             "approvers"
@@ -253,7 +253,7 @@ def remove_approver_from_group(
 def get_approver_group_by_experimenter(
     request: HttpRequest,
     experimenter_id: str,
-) -> tuple[int, ApproverGroupOut]:
+) -> tuple[HTTPStatus, ApproverGroupOut]:
     group = approver_group_get_by_experimenter_id(experimenter_id)
     if group is None:
         raise Http404
@@ -272,7 +272,7 @@ def get_approver_group_by_experimenter(
 )
 def get_review_settings(
     request: HttpRequest,
-) -> tuple[int, ReviewSettingsOut]:
+) -> tuple[HTTPStatus, ReviewSettingsOut]:
     settings = review_settings_load()
     return HTTPStatus.OK, ReviewSettingsOut.model_validate(settings)
 
@@ -290,7 +290,7 @@ def get_review_settings(
 def update_review_settings(
     request: HttpRequest,
     payload: ReviewSettingsUpdateIn,
-) -> tuple[int, ReviewSettingsOut]:
+) -> tuple[HTTPStatus, ReviewSettingsOut]:
     settings = review_settings_update(
         default_min_approvals=payload.default_min_approvals,
         allow_any_approver=payload.allow_any_approver,
@@ -312,7 +312,7 @@ def update_review_settings(
 def get_effective_policy(
     request: HttpRequest,
     experimenter_id: str,
-) -> tuple[int, EffectiveReviewPolicyOut]:
+) -> tuple[HTTPStatus, EffectiveReviewPolicyOut]:
     experimenter = get_object_or_404(User, pk=experimenter_id)
 
     if experimenter.role != UserRole.EXPERIMENTER: