chore(backend/api): naming improvements
This commit is contained in:
@@ -42,7 +42,7 @@ def list_users(
|
||||
search: str | None = None,
|
||||
limit: int = 50,
|
||||
offset: int = 0,
|
||||
) -> tuple[int, UserListOut]:
|
||||
) -> tuple[HTTPStatus, UserListOut]:
|
||||
qs = user_list(role=role, is_active=is_active, search=search)
|
||||
total = qs.count()
|
||||
items = [
|
||||
@@ -65,7 +65,7 @@ def list_users(
|
||||
def create_user(
|
||||
request: HttpRequest,
|
||||
payload: UserCreateIn,
|
||||
) -> tuple[int, UserOut]:
|
||||
) -> tuple[HTTPStatus, UserOut]:
|
||||
valid_roles = {choice[0] for choice in UserRole.choices}
|
||||
if payload.role not in valid_roles:
|
||||
raise ValidationError(
|
||||
@@ -100,7 +100,7 @@ def create_user(
|
||||
def get_user(
|
||||
request: HttpRequest,
|
||||
user_id: str,
|
||||
) -> tuple[int, UserOut]:
|
||||
) -> tuple[HTTPStatus, UserOut]:
|
||||
user = get_object_or_404(User, pk=user_id)
|
||||
return HTTPStatus.OK, UserOut.model_validate(user)
|
||||
|
||||
@@ -120,7 +120,7 @@ def update_user(
|
||||
request: HttpRequest,
|
||||
user_id: str,
|
||||
payload: UserUpdateIn,
|
||||
) -> tuple[int, UserOut]:
|
||||
) -> tuple[HTTPStatus, UserOut]:
|
||||
user = get_object_or_404(User, pk=user_id)
|
||||
|
||||
if payload.role is not None:
|
||||
@@ -159,7 +159,7 @@ def update_user(
|
||||
def delete_user(
|
||||
request: HttpRequest,
|
||||
user_id: str,
|
||||
) -> tuple[int, None]:
|
||||
) -> tuple[HTTPStatus, None]:
|
||||
user = get_object_or_404(User, pk=user_id)
|
||||
|
||||
current_user = getattr(request, "auth", None)
|
||||
@@ -185,7 +185,7 @@ def assign_role(
|
||||
request: HttpRequest,
|
||||
user_id: str,
|
||||
payload: UserRoleAssignIn,
|
||||
) -> tuple[int, UserOut]:
|
||||
) -> tuple[HTTPStatus, UserOut]:
|
||||
user = get_object_or_404(User, pk=user_id)
|
||||
|
||||
updated_user = user_assign_role(user=user, role=payload.role)
|
||||
|
||||
Reference in New Issue
Block a user